Not sure what the point was to make loads of addons update to LibBabble-Spell-3.0 when in not too long it's obsolete (2.4's GetSpellInfo()). They could have lived a fine life with Babble-Spell-2.2 for a little longer.
Lib-BabbleBoss-3.0 is a different matter possibly, though some addons would rather switch to a bossid solution hence again have to do two updates now instead of one...
Basically I wasted a chunk of time fixing something up that'll be gone once 2.4 hits live.
Not sure what the point was to make loads of addons update to LibBabble-Spell-3.0 when in not too long it's obsolete (2.4's GetSpellInfo()). They could have lived a fine life with Babble-Spell-2.2 for a little longer.
Lib-BabbleBoss-3.0 is a different matter possibly, though some addons would rather switch to a bossid solution hence again have to do two updates now instead of one...
Basically I wasted a chunk of time fixing something up that'll be gone once 2.4 hits live.
Are they adding SpellID's to UNIT_SPELLCAST_SENT or UNIT_SPELLCAST_START? I don't think the combat log will generate any entries that can replace these, and if that is correct and SpellID's are not added to those events, LibBabble-Spell will still be needed.
Are they adding SpellID's to UNIT_SPELLCAST_SENT or UNIT_SPELLCAST_START? I don't think the combat log will generate any entries that can replace these, and if that is correct and SpellID's are not added to those events, LibBabble-Spell will still be needed.
The 2.4 combat log event SPELL_CAST_START/_SUCCESS has the following args: spellId, spellName, spellSchool
I think those should match the current UNIT_SPELLCAST_START/_SENT events.
The 2.4 combat log event SPELL_CAST_START/_SUCCESS has the following args: spellId, spellName, spellSchool
I think those should match the current UNIT_SPELLCAST_START/_SENT events.
From what I tested, UNIT_SPELLCAST_START/_SENT are still fired, and needed to properly detect all spell events.
It should be seriously be suggested that UNIT_SPELLCAST_START/_SENT now returns spellIds instead of or in addition to spell names/rank if that hasn't happened already.
I can't post on the US UI forum or I'd suggest/inquire this.
It should be seriously be suggested that UNIT_SPELLCAST_START/_SENT now returns spellIds instead of or in addition to spell names/rank if that hasn't happened already.
I can't post on the US UI forum or I'd suggest/inquire this.
Please do, I don't have access to the US forum, and this would be a very helpful feature.
I can post a thread on the US UI forums, if someone hasn't already, but since I'm far from an expert on the topic would someone draft a post?
"Will UNIT_SPELLCAST_SENT/UNIT_SPELLCAST_START (and similar events) be extended to include the SpellID, to minimize the need for localization in addons, or will the new combat log events be able to completely replace these events?"
Actually this doesn't pertain to this threat, but Slouken asks about inconsistencies in the combat log in that last thread. Anyone minding posting the following in response to his request for further inconsistencies in the current PTR combat log? Thanks!
Shaman's greater fire elementals and greater earth elementals (from fire elemental totem and earth elemental totem) currently show the following flags for a solo shaman in the combat log:
That is they are 0x2218: Outsiders, friendly, NPC controlled guardians.
The main issue with this is the missing COMBATLOG_OBJECT_AFFILIATION_MINE which prevents it to identify a greater earth elemental to belong to the shaman hence multiple earth elementals cannot be attributed to their casters.
All other totem related damage works fine as they show as 0x2111 as flags.
I.e. they are mine, friendly, player-controlled, guardians which likely is a good flag setup for the elementals as well.
But maybe there should be a separate thread for PTR related stuff that Euro folks can't post. Or we can get Slouken to actually post on the EU UI forum, not that it has happened in 3 years :D
Now that I have hopefully completed the transition to Lib-Babble-Spell-3.0 here the information that is missing from the quick guide and are also missing from the Babble-3.0 and Babble-Spell-3.0 wikis:
local BS = LibStub("LibBabble-Spell-3.0"):GetLookupTable()
local reverseBS = LibStub("LibBabble-Spell-3.0"):GetReverseLookupTable()
*) :HasTranslation() and :HasReverseTranslation() along with :GetTranslation() and :GetReverseTranslation() are depricated and no longer needed.
*) BS[] and reverseBS[] will now return nil properly for non-existing translations
E.g. Old Babble-Spell-2.2 code like this
if BS:HasReverseTranslation(spell) then
spell=BS:GetReverseTranslation(spell)
else
spell = "Untranslatable spell"
end
now should read
spell = reverseBS[spell]
if spell==nil then
spell = "Untranslatable spell"
end
Observe that BS changed to reverseBS here.
EDIT: I just found that relevant documentation can be found in the wiki for LibBabble-Boss-3.0. May be worth fixing this so that API that is shared between all LB-3.0 libs is found under LibBabble-3.0. People who want to port to Babble-Spell won't necessarily look under Babble-Boss for information.
Yeah, there are many ways to do this. Mostly I wanted code that is explicit about how the change functions, though I like the compact version. The Babble-Boss wiki uses assert() which is another option.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Lib-BabbleBoss-3.0 is a different matter possibly, though some addons would rather switch to a bossid solution hence again have to do two updates now instead of one...
Basically I wasted a chunk of time fixing something up that'll be gone once 2.4 hits live.
Are they adding SpellID's to UNIT_SPELLCAST_SENT or UNIT_SPELLCAST_START? I don't think the combat log will generate any entries that can replace these, and if that is correct and SpellID's are not added to those events, LibBabble-Spell will still be needed.
The 2.4 combat log event SPELL_CAST_START/_SUCCESS has the following args: spellId, spellName, spellSchool
I think those should match the current UNIT_SPELLCAST_START/_SENT events.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumFrom what I tested, UNIT_SPELLCAST_START/_SENT are still fired, and needed to properly detect all spell events.
I can't post on the US UI forum or I'd suggest/inquire this.
Please do, I don't have access to the US forum, and this would be a very helpful feature.
"Will UNIT_SPELLCAST_SENT/UNIT_SPELLCAST_START (and similar events) be extended to include the SpellID, to minimize the need for localization in addons, or will the new combat log events be able to completely replace these events?"
http://forums.worldofwarcraft.com/thread.html?topicId=4665320632&postId=46649464201&sid=1#13
Seemed like an appropriate thread.
I think this is the place to get attention:
http://forums.worldofwarcraft.com/thread.html?topicId=2968233433&sid=1
But maybe there should be a separate thread for PTR related stuff that Euro folks can't post. Or we can get Slouken to actually post on the EU UI forum, not that it has happened in 3 years :D
local BS = LibStub("LibBabble-Spell-3.0"):GetLookupTable()
local reverseBS = LibStub("LibBabble-Spell-3.0"):GetReverseLookupTable()
*) :HasTranslation() and :HasReverseTranslation() along with :GetTranslation() and :GetReverseTranslation() are depricated and no longer needed.
*) BS[] and reverseBS[] will now return nil properly for non-existing translations
E.g. Old Babble-Spell-2.2 code like this
now should read
Observe that BS changed to reverseBS here.
EDIT: I just found that relevant documentation can be found in the wiki for LibBabble-Boss-3.0. May be worth fixing this so that API that is shared between all LB-3.0 libs is found under LibBabble-3.0. People who want to port to Babble-Spell won't necessarily look under Babble-Boss for information.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumor