Load on Demand via OptDep/ReqDep is BROKEN for 3.0.2

#1 Oct 14, 2008
Forge_User_96189362
Forge_User_96189362

View User Profile

View Posts

Send Message
Forum Moderator
- Join Date: 5/8/2006
- Posts: 283
- Member Details
Short story: OptDep/ReqDep will NOT load Load-on-Demand libraries for 3.0.2.
See the UI forums thread.

Any libraries/addons relying on OptDep/ReqDep to be loaded, need to unset LoD for the duration of patch 3.0.2. It will be fixed in 3.0.3.

This does NOT affect addons/libraries that get loaded via explicit LoadAddOn() calls, such as addons loaded by e.g. AddonLoader.

Rollback Post to Revision RollBack
#2 Oct 14, 2008
Adirelle
Adirelle

View User Profile

View Posts

Send Message
Curse Premium
- Location: Lyon, France
- Join Date: 9/3/2008
- Posts: 2,404
- Member Details
Nevcariel script-fixed the LibStub libraries, see : http://forums.wowace.com/showthread.php?t=14405

LibRock and Ace2 libraries should be unaffected, as both LibRock and AceLibrary use LoadAddOn when needed.

Rollback Post to Revision RollBack
#3 Oct 14, 2008
Forge_User_35441137
Forge_User_35441137

View User Profile

View Posts

Send Message
- Join Date: 11/20/2007
- Posts: 2,148
- Member Details
Quote from Mikk

Any libraries/addons relying on OptDep/ReqDep to be loaded, need to unset LoD for the duration of patch 3.0.2. It will be fixed in 3.0.3.

This does NOT affect addons/libraries that get loaded via explicit LoadAddOn() calls, such as addons loaded by e.g. AddonLoader.

Glad to head the upcoming fix and that AddonLoader isn't affected. :)

Rollback Post to Revision RollBack
#4 Oct 20, 2008
nevcairiel
nevcairiel

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Hamburg
- Join Date: 8/27/2005
- Posts: 1,934
- Member Details
Quote from Adirelle
Nevcariel script-fixed the LibStub libraries, see : http://forums.wowace.com/showthread.php?t=14405

LibRock and Ace2 libraries should be unaffected, as both LibRock and AceLibrary use LoadAddOn when needed.

Indeed. I kept a list of libs i fixed and will revert the change once 3.0.3 hits and fixes the bug.

Rollback Post to Revision RollBack
#5 Oct 20, 2008
Forge_User_35441137
Forge_User_35441137

View User Profile

View Posts

Send Message
- Join Date: 11/20/2007
- Posts: 2,148
- Member Details
I love you Nev :P

Rollback Post to Revision RollBack
#6 Nov 5, 2008
Forge_User_96189362
Forge_User_96189362

View User Profile

View Posts

Send Message
Forum Moderator
- Join Date: 5/8/2006
- Posts: 283
- Member Details
In other news, the LoD bug is still alive and well in 3.0.3 even tho Zoot said he'd fixed it. Boo.

So, yeah, don't set your libs back to LoD just yet.

Edit: My own test case was ReqDepped. Good thing I tested that I guess.

Last edited by Forge_User_96189362: Nov 6, 2008

Rollback Post to Revision RollBack
#7 Nov 5, 2008
Xinhuan
Xinhuan

View User Profile

View Posts

Send Message
Curse Premium
- Location: Singapore
- Join Date: 9/15/2008
- Posts: 4,035
- Member Details
Quote from Mikk
In other news, the LoD bug is still alive and well in 3.0.3 even tho Zoot said he'd fixed it. Boo.

So, yeah, don't set your libs back to LoD just yet.

Err, I tested. Seems fixed to me in 3.0.3!

Edit after further tests:
OptionalDeps on LoD addons is fixed.
But RequiredDeps on LoD addons is not fixed.

Followup posted here:
http://forums.worldofwarcraft.com/thread.html?topicId=10971929880&postId=123275959757&sid=1#10

Last edited by Xinhuan: Nov 5, 2008

Rollback Post to Revision RollBack
#8 Nov 6, 2008
nevcairiel
nevcairiel

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Hamburg
- Join Date: 8/27/2005
- Posts: 1,934
- Member Details
Hm so.

Addons shouldn't generally ReqDep on a Lib, should they?
Can i restore the LoD to the libs where i removed it from?

Rollback Post to Revision RollBack
#9 Nov 6, 2008
Xinhuan
Xinhuan

View User Profile

View Posts

Send Message
Curse Premium
- Location: Singapore
- Join Date: 9/15/2008
- Posts: 4,035
- Member Details
Quote from Nevcairiel
Hm so.

Addons shouldn't generally ReqDep on a Lib, should they?
Can i restore the LoD to the libs where i removed it from?

Paste the list of Libs that you modified, so we can take a look and see if any of those libs are special enough to have addons ReqDep them?

Rollback Post to Revision RollBack

#10 Nov 6, 2008

Forum Moderator

Forum Moderator

Location: Hamburg
Join Date: 8/27/2005
Posts: 1,934
Member Details

ItemPrice-1.1/ItemPrice-1.1.toc
LibAvion-2.0/LibAvion-2.0.toc
LibAvionOptions-2.0/LibAvionOptions-2.0.toc
LibBabble-Boss-3.0/LibBabble-Boss-3.0.toc
LibBabble-Class-3.0/LibBabble-Class-3.0.toc
LibBabble-CreatureType-3.0/LibBabble-CreatureType-3.0.toc
LibBabble-Faction-3.0/LibBabble-Faction-3.0.toc
LibBabble-Inventory-3.0/LibBabble-Inventory-3.0.toc
LibBabble-TalentTree-3.0/LibBabble-TalentTree-3.0.toc
LibBabble-Zone-3.0/LibBabble-Zone-3.0.toc
LibBars-1.0/LibBars-1.0.toc
LibCooldown-Item-2.0/LibCooldown-Item-2.0.toc
LibCooldown-Spell-2.0/LibCooldown-Spell-2.0.toc
LibDebugLog-1.0/LibDebugLog-1.0.toc
LibDogTag-3.0/LibDogTag-3.0.toc
LibDogTag-Items-3.0/LibDogTag-Items-3.0.toc
LibDogTag-Unit-3.0/LibDogTag-Unit-3.0.toc
LibFriends-1.0/LibFriends-1.0.toc
LibFuBarPlugin-3.0/LibFuBarPlugin-3.0.toc
LibGraph-2.0/LibGraph-2.0.toc
LibGuild-1.0/LibGuild-1.0.toc
LibGuildPositions-1.0/LibGuildPositions-1.0.toc
LibInventory-2.1/LibInventory-2.1.toc
LibItemBonus-2.0/LibItemBonus-2.0.toc
LibKeyBound-1.0/LibKeyBound-1.0.toc
LibKeyBoundExtra-1.0/LibKeyBoundExtra-1.0.toc
LibLogger-1.0/LibLogger-1.0.toc
LibMMButton-1.0/LibMMButton-1.0.toc
LibPeriodicTable-3.1/LibPeriodicTable-3.1.toc
LibQuixote-2.0/LibQuixote-2.0.toc
LibSharedMedia-3.0/LibSharedMedia-3.0.toc
LibSimpleFrame-1.0/LibSimpleFrame-1.0.toc
LibSimpleOptions-1.0/LibSimpleOptions-1.0.toc
LibSimpleTimer-1.0/LibSimpleTimer-1.0.toc
LibSink-2.0/LibSink-2.0.toc
LibStickyFrames-1.0/LibStickyFrames-1.0.toc
LibStickyFrames-2.0/LibStickyFrames-2.0.toc
LibTalentQuery-1.0/LibTalentQuery-1.0.toc
LibTourist-3.0/LibTourist-3.0.toc
LibAbacus-3.0/LibAbacus-3.0.toc
LibCrayon-3.0/LibCrayon-3.0.toc
LibGratuity-3.0/LibGratuity-3.0.toc
LibJostle-3.0/LibJostle-3.0.toc

Thats the list my script stripped the LoD from and would add it back

#11 Nov 6, 2008
Xinhuan
Xinhuan

View User Profile

View Posts

Send Message
Curse Premium
- Location: Singapore
- Join Date: 9/15/2008
- Posts: 4,035
- Member Details
ItemPrice-1.1 seems like the only one that an addon might ReqDep.

Rollback Post to Revision RollBack
#12 Nov 6, 2008
_ForgeUser618
_ForgeUser618

View User Profile

View Posts

Send Message
- Join Date: 1/27/2005
- Posts: 961
- Member Details
This reminds me on my suggestion to let the packager add disembedded libraries to the required deps field instead using the soft fallback optdeps .)

Rollback Post to Revision RollBack
#13 Nov 6, 2008
nevcairiel
nevcairiel

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Hamburg
- Join Date: 8/27/2005
- Posts: 1,934
- Member Details
Quote from dafire
This reminds me on my suggestion to let the packager add disembedded libraries to the required deps field instead using the soft fallback optdeps .)

I hope it never does, its an ugly hack, and it really should not modify the .toc like this without any explicit control tags.

What if i have a library thats purely optional, but i package it by default? In disembed mode, its not optional anymore? :D

And it would break the LoD again =P

Rollback Post to Revision RollBack
#14 Nov 6, 2008
_ForgeUser188529
_ForgeUser188529

View User Profile

View Posts

Send Message
- Join Date: 12/29/2006
- Posts: 476
- Member Details
Quote from Nevcairiel
I hope it never does, its an ugly hack, and it really should not modify the .toc like this without any explicit control tags.

What if i have a library thats purely optional, but i package it by default? In disembed mode, its not optional anymore? :D

And it would break the LoD again =P

If it's optional, then it shouldn't be installed by default, imho.

break19

Rollback Post to Revision RollBack
#15 Nov 6, 2008
sylvanaar
sylvanaar

View User Profile

View Posts

Send Message
Curse Premium
- Location: Redondo Beach, CA
- Join Date: 11/1/2006
- Posts: 2,884
- Member Details
Quote from break19
If it's optional, then it shouldn't be installed by default, imho.

break19

Rule of thumb: required dependency is for modules

Optional dependency is used (by some) for libraries, but I don't think that is even correct. Personally, LoadAddon is a better choice than OptDep, because optdep forces it to load earlier than it needs to (for no good reason).

Rollback Post to Revision RollBack
#16 Nov 6, 2008
nevcairiel
nevcairiel

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Hamburg
- Join Date: 8/27/2005
- Posts: 1,934
- Member Details
Quote from break19
If it's optional, then it shouldn't be installed by default, imho.

break19

Alot of AddOns i know choose stuff to be optional so that people are able to disable/remove it without breaking/hacking the addon. Makes perfect sense to me, and alot of others too, apparently.

Like LibHealComm for example. Addons support it, and even package it by default, but its not required for the addon to function, so its support is designed to be optional. Perfect design in alot of aspects.

Rollback Post to Revision RollBack
#17 Nov 7, 2008
Xinhuan
Xinhuan

View User Profile

View Posts

Send Message
Curse Premium
- Location: Singapore
- Join Date: 9/15/2008
- Posts: 4,035
- Member Details
New issue found by ArrowMaster and me:

http://forums.worldofwarcraft.com/thread.html?topicId=12354805813&sid=1

Rollback Post to Revision RollBack
#18 Nov 7, 2008
nevcairiel
nevcairiel

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Hamburg
- Join Date: 8/27/2005
- Posts: 1,934
- Member Details
Does that in any way block LoD libraries from loading?

Rollback Post to Revision RollBack
#19 Nov 7, 2008
Xinhuan
Xinhuan

View User Profile

View Posts

Send Message
Curse Premium
- Location: Singapore
- Join Date: 9/15/2008
- Posts: 4,035
- Member Details
Don't think so... yet. I've heard of some stories where Pitbull modules stopped loading though, and it has to do with the ReqDep/OptDep/LoD/IsAddOnLoaded/ReloadUI mess.

Rollback Post to Revision RollBack
#20 Jan 21, 2009
jokeyrhyme
jokeyrhyme

View User Profile

View Posts

Send Message
Curse Premium
- Location: Central Coast NSW
- Join Date: 8/19/2008
- Posts: 433
- Member Details
Has anyone confirmed that this is still the case in 3.0.8?

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.

Previous Thread

Next Thread