Authors CurseForge

works for me now !!

my only problem is: i can't move the tab when rolling for an item. its stuck and I get errors. any fix for that? :)

thx

you are my hero :D thanks a lot !! <3

<3  

Quote from Xuerian >>

Quote from Azona >>

This addon work mostly of time fine. only error I so far got when rolling on items comes to pass, havent copied code yet as dint went here yet to check if was even planned.

 

if I find errors and can copy whem ill post them, but wont be playing in group anymore untill later today.

 

Quote from horologue >>

In reply to Xuerian:

 will do. it will most likely be Tuesday as I am at PAX West for the next 4 days 

 Try this:

 

XLoot_Frame\Frame.lua:243

 

Replace

		do

 With

		if GetCurrencyInfo then

And in XLoot\helpers.lua:99

 

Replace

	local role = UnitGroupRolesAssigned(name)

 with

	local role = 'NONE'
	if UnitGroupRolesAssigned then
		role = UnitGroupRolesAssigned(name)
	end

 

 I tried the Version horologue shared and still getting a lua error:

Date: 2019-09-14 11:04:22
ID: 1
Error occured in: Global
Count: 108
Message: ..\AddOns\XLoot_Monitor\Monitor.lua line 142:
   attempt to call global 'GetCurrencyInfo' (a nil value)
Debug:
   XLoot_Monitor\Monitor.lua:142: ?()
   XLoot_Monitor\Monitor.lua:154: LOOT_EVENT()
   XLoot_Monitor\Monitor.lua:448: ?()
   XLoot_Monitor\Monitor.lua:487:
      XLoot_Monitor\Monitor.lua:480
Locals:
id = 81
num = 1
num = 1
(*temporary) = nil
(*temporary) = 81
(*temporary) = "attempt to call global 'GetCurrencyInfo' (a nil value)"
opt = <table> {
 threshold_own = 2
 use_altoholic = true
 show_currency = true
 font_flag = "OUTLINE"
 fade_other = 5
 font_size_ilvl = 8
 anchor = <table> {
 }
 fade_own = 10
 font_size_loot = 12
 show_totals = false
 font = "Fonts\FRIZQT__.TTF"
 show_ilvl = false
 show_crafted = false
 name_width = 50
 font_size_quantity = 10
 threshold_other = 3
 show_coin = false
}
addon = <table> {
 SetDefaultModuleLibraries = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:367
 Highlight = <function> defined @Interface\AddOns\XLoot\skins.lua:352
 OnInitialize = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:66
 NewModule = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:235
 EnableModule = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:332
 modules = <table> {
 }
 GetModule = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:210
 IterateEmbeds = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:442
 defaultModuleLibraries = <table> {
 }
 MODIFIER_STATE_CHANGED = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:160
 EframeUpdate = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:170
 UpdateAnchors = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:389
 GetName = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:279
 _skin_data = <table> {
 }
 name = "XLoot_Monitor"
 IsEnabled = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:451
 orderedModules = <table> {
 }
 DisableModule = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:350
 CreateRow = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:334
 RemoveRow = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:188
 Reskin = <function> defined @Interface\AddOns\XLoot\skins.lua:322
 IsModule = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:217
 db = <table> {
 }
 SetDefaultModuleState = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:387
 Skin = <function> defined @Interface\AddOns\XLoot\skins.lua:343
 ShowOptions = <function> defined @Interface\AddOns\XLoot\XLoot.lua:85
 SetEnabledState = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:424
 opt = <table> {
 }
 enabledState = true
 baseName = "XLoot_Monitor"
 Enable = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:294
 Restack = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:240
 SlashHandler = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:397
 AddRow = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:208
 ApplyOptions = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:90
 IterateModules = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:437
 SetDefaultModulePrototype = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:409
 LOOT_EVENT = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:153
 OnEnable = <function> defined @Interface\AddOns\XLoot_Monitor\Monitor.lua:73
 moduleName = "Monitor"
 defaultModuleState = true
 Disable = <function> defined @Interface\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:314
}

AddOns:
  Swatter, v8.2.6377 (SwimmingSeadragon)
  AdiBags, vv1.9.17-classic
  AtlasLootClassic, vv1.1.10
  AtlasLootClassicMaps, vv1.0.0
  AucAdvanced, v8.2.6385 (SwimmingSeadragon)
  AucFilterBasic, v8.2.6364 (SwimmingSeadragon)
  AucStatHistogram, v8.2.6366 (SwimmingSeadragon)
  AucStatiLevel, v8.2.6370 (SwimmingSeadragon)
  AucStatPurchased, v8.2.6367 (SwimmingSeadragon)
  AucStatSimple, v8.2.6368 (SwimmingSeadragon)
  AucStatStdDev, v8.2.6369 (SwimmingSeadragon)
  AucUtilFixAH, v8.2.6371 (SwimmingSeadragon)
  BankStack, vv11302.0
  BeanCounter, v8.2.6381 (SwimmingSeadragon)
  ClassicCodex, v1.2.1
  Details, v
  DetailsTinyThreat, v
  Dominos, v8.2.25
  DominosCast, v
  DominosConfig, v
  DominosEncounter, v
  DominosProgress, v
  DominosRoll, v
  Enchantrix, v8.2.6392 (SwimmingSeadragon)
  FishingBuddy, v0.4
  GatherMate2, v1.45
  InFlightLoad, v1.13.002
  Informant, v8.2.6374 (SwimmingSeadragon)
  KiwiPlates, vr56
  LeatrixMaps, v1.13.30
  LeatrixPlus, v1.13.30
  Masque, v8.2.7-Classic
  MasqueQhil, v1.2.1
  MikScrollingBattleText, v5.7.149
  NugRunning, v1.13.19
  NugRunningOptions, v
  OmniCC, v8.2.4
  OmniCCConfig, v
  Prat30, v3.7.36
  Prat30Libraries, v
  Quartz, v3.5.1
  RealMobHealth, v2.10
  RecipeRadarClassic, v1.0.0.4
  ShadowedUnitFrames, vv4.2-Classic-Beta7
  SlideBar, v8.2.6375 (SwimmingSeadragon)
  SmartBuff, v1.13.2c
  Spy, v1.0.5
  Stubby, v8.2.6376 (SwimmingSeadragon)
  TinyTooltip, v8.2.1
  TitanClassic, v1.0.7.11302
  TitanClassicAmmo, v1.0.7.11302
  TitanClassicBag, v1.0.7.11302
  TitanClassicClock, v1.0.7.11302
  TitanClassicGold, v1.0.7.11302
  TitanClassicLocation, v1.0.7.11302
  TitanClassicLootType, v1.0.7.11302
  TitanClassicPerformance, v1.0.7.11302
  TitanClassicRepair, v1.0.7.11302
  TitanClassicVolume, v1.0.7.11302
  TitanClassicXP, v1.0.7.11302
  tullaRange, v8.2.2
  tullaRangeConfig, v
  WhatsTraining, v1.8.3
  XLoot, v8.1-1
  XLootFrame, v8.1-1
  XLootGroup, v8.1-1
  XLootMaster, v8.1-1
  XLootMonitor, v8.1-1
  XLootOptions, v8.1-1
  ZygorGuidesViewerClassic, v1.0
  BlizRuntimeLib_deDE v1.13.2.11302 <none>
  (ck=819)

Quote from horologue >>

Those changes fixed the lua errors caused by clicking options in the config menu. As far as I can tell, the addon is now fully functional.

 

I don't know if you wish to update the formal addon on the curse page, but if you do with those two alterations, you could also mark it as working for classic.  I am going to share the fixed version with my guildmates. I will not post an updated version to the public without your permission. it's also worth noting that I know nothing about coding.

 Thanks for Sharing!

Quote from Xuerian >>

Quote from horologue >>

Those changes fixed the lua errors caused by clicking options in the config menu. As far as I can tell, the addon is now fully functional.

 

I don't know if you wish to update the formal addon on the curse page, but if you do with those two alterations, you could also mark it as working for classic.  I am going to share the fixed version with my guildmates. I will not post an updated version to the public without your permission. it's also worth noting that I know nothing about coding.

 You can share it. I was going to push an update, then I found my configuration for pushing updates is broken or out of date, and there's zero documentation for it on curseforge and I couldn't be assed.

 I hope you will update it some day for WOW Classic, Xloot was one of my favorite QOL Addons in the past. <3

i get this error in classic wow, and the Blue rolls do not disappear after the dice.

green rols are ok

271x XLoot\helpers.lua:111: bad argument #2 to 'string_format' (string expected, got nil)
[C]: ?
XLoot\helpers.lua:111: in function <XLoot\helpers.lua:90>
XLoot_Group\Group-Gruppe.lua:640: in function <XLoot_Group\Group.lua:635>
XLoot_Group\Group-Gruppe.lua:720: in function <XLoot_Group\Group.lua:669>
XLoot_Group\Group-Gruppe.lua:759: in function <XLoot_Group\Group.lua:756>

Locals:
(*temporary) = "|TLFGFRAME\LFGROLE:12:12:-1:0:64:16:%s:0:16|t%s"
(*temporary) = nil
(*temporary) = "Schibeleköks"
(*temporary) = "string expected, got nil"

Hi!

  I'm a new user of Xloot,  How can I change the language? Many thanks!

There is a problem with the integration of the Pawn addon into XLoot.

It doesn't show an upgrade for items with random stats on them. The reason is, that an ItemId doesn't contain informations about the random values, but an ItemLink does. The called function PawnIsItemIDAnUpgrade(id) searches for a link to this item in the cache, but if you didn't loot the Item yet, there is no information in the cache. Therefore, it never shows it as an upgrade.

There is a workaround for this problem: Pawn has two functions (which are called by PawnIsItemIDAnUpgrade(id) after searching the cache) PawnGetItemData(link) and PawnIsItemAnUpgrade(Item). In helpers.lua, the function XLoot.IsItemUpgrade(link) kinda destroys the item link, by reading out its id before calling PawnIsItemIDAnUpgrade(id). So the easy fix will be, to just call PawnGetItemData(link) and PawnIsItemAnUpgrade(Item).

This is reached by replacing the lines

	local id = string.match(link, "item:(%d+)")
	if PawnIsItemIDAnUpgrade and id and PawnIsItemIDAnUpgrade(id) then

 by

	local Item = PawnGetItemData(link)
	if PawnIsItemAnUpgrade and Item and PawnIsItemAnUpgrade(Item) then

Is there any way to make auto looting work with items with a comma in them?

For example "Gar'tok, Strength of the Faithful" is being read by the addon as "Gar'tok" and "Strength of the Faithful" and thus not being auto looted.

Hi @xuerian, any chance for Shadowlands beta\PTR version?

Please :)

cheers

Unfortunately not. When I tried first, it gave lua error at start, I didn't save it, as many addons did the same, I just turned it off. Now I tried again, and at start I didn't get lua error, but when I looting something:

(version info:)

## Interface: 80200
## Title: XLoot
## Notes: Core module for Loot and Looting-related UI improvements
## Version: 8.2-1

Message: Interface\AddOns\XLoot\skins.lua:192: attempt to call method 'SetBackdrop' (a nil value)
Time: Fri Aug 28 10:44:08 2020
Count: 1
Stack: Interface\AddOns\XLoot\skins.lua:192: attempt to call method 'SetBackdrop' (a nil value)
[string "@Interface\AddOns\XLoot\skins.lua"]:192: in function `Backdrop'
[string "@Interface\AddOns\XLoot\skins.lua"]:204: in function `Skin'
[string "@Interface\AddOns\XLoot\skins.lua"]:347: in function `Skin'
[string "@Interface\AddOns\XLoot_Frame\Frame.lua"]:1017: in function `BuildLootFrame'
[string "@Interface\AddOns\XLoot_Frame\Frame.lua"]:1129: in function `Update'
[string "@Interface\AddOns\XLoot_Frame\Frame.lua"]:1300: in function `?'
[string "@Interface\AddOns\XLoot\XLoot.lua"]:39: in function <Interface\AddOns\XLoot\XLoot.lua:37>

Locals: self = <table> {
 current = <table> {
 }
 Highlight = <function> defined @Interface\AddOns\XLoot\skins.lua:253
 UpdateSkin = <function> defined @Interface\AddOns\XLoot\skins.lua:222
 SkinRaw = <function> defined @Interface\AddOns\XLoot\skins.lua:218
 Backdrop = <function> defined @Interface\AddOns\XLoot\skins.lua:191
 masque_tweaks = <table> {
 }
 Skin = <function> defined @Interface\AddOns\XLoot\skins.lua:198
 skins = <table> {
 }
 Gradient = <function> defined @Interface\AddOns\XLoot\skins.lua:180
 base = <table> {
 }
 UpdateHighlight = <function> defined @Interface\AddOns\XLoot\skins.lua:269
}
frame = <unnamed> {
 0 = <userdata>
 _skin_options = <table> {
 }
}
opt_backdrop = nil
(*temporary) = nil
(*temporary) = <unnamed> {
 0 = <userdata>
 _skin_options = <table> {
 }
}
(*temporary) = <table> {
 insets = <table> {
 }
 bgFile = "Interface\ChatFrame\ChatFrameBackground"
 tileSize = 16
 tile = true
}
(*temporary) = "attempt to call method 'SetBackdrop' (a nil value)"
backdrop = <table> {
 insets = <table> {
 }
 bgFile = "Interface\ChatFrame\ChatFrameBackground"
 tileSize = 16
 tile = true
}
bd_color = <table> {
 1 = 0
 2 = 0
 3 = 0
 4 = 0.900000
}

Quote from Xuerian >>

 

You might be able to get some of it working with

 

skins.lua:192 at the top of lib:backdrop() insert new lines:

 

if BackdropTemplateMixin then

  Mixin(frame, BackdropTemplateMixin)

end

 

 You can access the PTR now without sub. They have the Shadowlands pre-patch on it, which I guess the same environment like the beta\next expansion. I guess they will patch this up to live in a month, so probably is up there for a few weeks.

I've tried to inject this code, but got more lua errors

Message: Interface\SharedXML\Mixin.lua:29: attempt to index local 'object' (a nil value)
Time: Sat Aug 29 09:49:15 2020
Count: 1
Stack: Interface\SharedXML\Mixin.lua:29: attempt to index local 'object' (a nil value)
[string "@Interface\SharedXML\Mixin.lua"]:29: in function `Mixin'
[string "@Interface\AddOns\XLoot\skins.lua"]:193: in main chunk

Locals: object = nil
(for index) = 1
(for limit) = 1
(for step) = 1
i = 1
mixin = <table> {
 SetBorderBlendMode = <function> defined @Interface\SharedXML\Backdrop.lua:319
 GetEdgeSize = <function> defined @Interface\SharedXML\Backdrop.lua:241
 SetBackdropBorderColor = <function> defined @Interface\SharedXML\Backdrop.lua:475
 GetBackdropBorderColor = <function> defined @Interface\SharedXML\Backdrop.lua:462
 ApplyBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:347
 OnBackdropLoaded = <function> defined @Interface\SharedXML\Backdrop.lua:205
 ClearBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:335
 GetBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:400
 GetBackdropColor = <function> defined @Interface\SharedXML\Backdrop.lua:443
 SetupTextureCoordinates = <function> defined @Interface\SharedXML\Backdrop.lua:267
 OnBackdropSizeChanged = <function> defined @Interface\SharedXML\Backdrop.lua:235
 HasBackdropInfo = <function> defined @Interface\SharedXML\Backdrop.lua:331
 SetBackdropColor = <function> defined @Interface\SharedXML\Backdrop.lua:452
 SetBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:382
 SetupPieceVisuals = <function> defined @Interface\SharedXML\Backdrop.lua:299
}
(for generator) = <function> defined =[C]:-1
(for state) = <table> {
 SetBorderBlendMode = <function> defined @Interface\SharedXML\Backdrop.lua:319
 GetEdgeSize = <function> defined @Interface\SharedXML\Backdrop.lua:241
 SetBackdropBorderColor = <function> defined @Interface\SharedXML\Backdrop.lua:475
 GetBackdropBorderColor = <function> defined @Interface\SharedXML\Backdrop.lua:462
 ApplyBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:347
 OnBackdropLoaded = <function> defined @Interface\SharedXML\Backdrop.lua:205
 ClearBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:335
 GetBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:400
 GetBackdropColor = <function> defined @Interface\SharedXML\Backdrop.lua:443
 SetupTextureCoordinates = <function> defined @Interface\SharedXML\Backdrop.lua:267
 OnBackdropSizeChanged = <function> defined @Interface\SharedXML\Backdrop.lua:235
 HasBackdropInfo = <function> defined @Interface\SharedXML\Backdrop.lua:331
 SetBackdropColor = <function> defined @Interface\SharedXML\Backdrop.lua:452
 SetBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:382
 SetupPieceVisuals = <function> defined @Interface\SharedXML\Backdrop.lua:299
}
(for control) = "SetBorderBlendMode"
k = "SetBorderBlendMode"
v = <function> defined @Interface\SharedXML\Backdrop.lua:319
(*temporary) = "SetBorderBlendMode"
(*temporary) = "attempt to index local 'object' (a nil value)"

 and

Message: Interface\AddOns\XLoot\XLoot.lua:128: attempt to call method 'SkinsOnInitialize' (a nil value)
Time: Sat Aug 29 09:49:15 2020
Count: 1
Stack: Interface\AddOns\XLoot\XLoot.lua:128: attempt to call method 'SkinsOnInitialize' (a nil value)
[string "@Interface\AddOns\XLoot\XLoot.lua"]:128: in function <Interface\AddOns\XLoot\XLoot.lua:120>
[string "=[C]"]: ?
[string "@Interface\AddOns\Details\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:70: in function <...ce\AddOns\Details\Libs\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@Interface\AddOns\Details\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:498: in function `InitializeAddon'
[string "@Interface\AddOns\Details\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:613: in function <...ce\AddOns\Details\Libs\AceAddon-3.0\AceAddon-3.0.lua:605>

Locals: <none>