Thanks, Adirelle - working great so far. :) I'll have to fiddle later to see if there would be a way to make a skinning module or something.
One question that I forgot to ask, though. Your changelog keeps referencing a README, but there isn't one in the download. Is it referring to something else? Or is it being ignored by the packager for some reason? (I haven't browsed to the repository.)
There is a README.textile, that is used in to update the project main page (and is also used by github, that I update more often, with potentially broken commits) but I exclude it from the wowace package.
I really love this new addon very much, great work!
I am only missing one feature: The possibility to buy additional bag space at the bank.
Do you think this feature can make it in?
Heya, Adirelle. Very nice work so far on this, I love it. A few comments/questions. Forgive me if anything has already been covered.
Does AdiBags have the ability to show your bank everywhere yet? If so, I couldn't figure out how to do it this morning. A keybind would be nice (didn't see one).
I'd suggest a Tabards filter out of the box.
A shorter slash command option might be nice (/ab).
I have a couple quest items in the bank at the moment, and although they have the quest highlight (yellow border), they get put into the Consumable category in the bank for some reason. Do filters operate differently in the bank, or is that a bug?
There may be a minor issue with the N button. Steps to reproduce:
Take an item out of the bank and put it in your bag
Right click that item in your bag; it gets put back into the bank under the New category
The N button on the bank frame now becomes enabled. Click it.
Nothing happens (this is the bug).
If you then close the bank window and open it again, clicking N works properly.
Question: Is your sort a stable sort? During a boss fight, sometimes I need to open my bags to use a consumable that I didn't have on my bars. I use muscle memory and spatial organization to know exactly where it will be. A stable sort would help this (I don't know if you sort by category then by name, or how it works).
Very cool add-on so far! I'll probably have more feedback as I use it more, this was just my first 10 minute impression. :)
3) Isn't /ab used for something else ? (You can also right click the LDB plugin)
4) Strange. The quest items I tested got listed in the Quest category. But they are LK items. Maybe earlier items weren't tagged properly in the Blizzard database. Could you link them please ?
5) I have to rewrite the new item tracker. It has some other issues.
6) The default sort orders by :
- if both items can be equipped, inventory slot,
- AH category (alphabetically),
- AH subcategory (alphabetically),
- decreasing quality,
- decreasing item level,
- item name (alphabetically).
This is was is used inside one section. Each section is sorted independently of the others. Moreover, due to the laying-out algorithm, sections can move depending on the number of sections and the number of items inside them.
Yes I know. Note that is matched the AH category. BTW, wowhead.com almost reproduces the AH categories. There you can see the HearthStone goes into Miscellaneous, Junk:
I would be more interested in quest items that aren't categorized as Quest, though I think I'll just add a "quest item" filter, that will test the item quest status. The latest way to detect a quest item is to look for "Quest" in the item tooltip. Until now, I didn't need to parse tooltips and I woud like to avoid it.
I have one small problem with virtual stack:
When you're trading with someone or sending items through mail, you can click one time on the virtual stack to give one stack, but if you try to click more times no more stack are traded or put in the mail frame. (In baggins with virtual stack you could click on the virtual stack as long as there was some items left on the virtual stack).
Can this be fixed? (If not can we have a button to temporarilly disable virtual stack)
4) I have a couple quest items in the bank at the moment, and although they have the quest highlight (yellow border), they get put into the Consumable category in the bank for some reason. Do filters operate differently in the bank, or is that a bug?
5) There may be a minor issue with the N button.
I added a quest item filter and rewrote the new item tracker, so these two points should be fixed.
That's too bad. I won't be able to use AdiBags in that case. :(
I'm reusing Blizzard code, widget templates and bag/bank events at the most. Pushing an additional layer to handle "anywhere bank" in the current code would be a nightmare. Plus it would make AdiBags either too complex or too dependent of another mod.
You could use one of the other mods that serve that purpose.
No, I would need my bank categorized and laid out the same way everywhere. The categorization features are only useful if they can always be used. I unfortunately rely on seeing my bank everywhere far too much to lose it.
I am - one of the things I've noticed is that category names are sometimes either truncated to late, resulting in "..." outside of the bag frame, or too early, leaving space between the center-top of the rightmost container button and the right edge of the bag frame.
The early version used to grow the section to display the complete name. It resulted in a lot a wasted space (imagine a section named "Enchantement d'armure" containing only one item). The current version define the title width to the width of the items plus the space between sections (see then fancy ASCII schema below) then the Blizzard algorithm does its job. i don't how I could make this better.
+--------------------+
+ this title is w... +
+-------+-------+----+
| | |
| item1 | item2 |
| | |
+-------+-------+
I'm still using alpha:)
yesterday evening the behaviour was very strange:
equipment was no more divided in sets
palading blessing component (symbol of kings) which normally stack by 100, I had something lilke 306 symbol in my bags, virtual stack were activated but it was displayed as four stack (three stack of 100 and one stack of 6)
I've seen in the change log that incomplete stack should now be displayed in a separate stack (could it be possible to have an option to show incomplete stack in the virtual stack?)
palading blessing component (symbol of kings) which normally stack by 100, I had something lilke 306 symbol in my bags, virtual stack were activated but it was displayed as four stack (three stack of 100 and one stack of 6)
Really strange. Could you print me the result of "/print GetItemInfo()"
I've seen in the change log that incomplete stack should now be displayed in a separate stack (could it be possible to have an option to show incomplete stack in the virtual stack?)
Done.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
One question that I forgot to ask, though. Your changelog keeps referencing a README, but there isn't one in the download. Is it referring to something else? Or is it being ignored by the packager for some reason? (I haven't browsed to the repository.)
I am only missing one feature: The possibility to buy additional bag space at the bank.
Do you think this feature can make it in?
Keep up the great work!
X-buZZ
1) No it doesn't. And it won't.
2) Might happen.
3) Isn't /ab used for something else ? (You can also right click the LDB plugin)
4) Strange. The quest items I tested got listed in the Quest category. But they are LK items. Maybe earlier items weren't tagged properly in the Blizzard database. Could you link them please ?
5) I have to rewrite the new item tracker. It has some other issues.
6) The default sort orders by :
- if both items can be equipped, inventory slot,
- AH category (alphabetically),
- AH subcategory (alphabetically),
- decreasing quality,
- decreasing item level,
- item name (alphabetically).
This is was is used inside one section. Each section is sorted independently of the others. Moreover, due to the laying-out algorithm, sections can move depending on the number of sections and the number of items inside them.
http://www.wowhead.com/item=6948/hearthstone
I would be more interested in quest items that aren't categorized as Quest, though I think I'll just add a "quest item" filter, that will test the item quest status. The latest way to detect a quest item is to look for "Quest" in the item tooltip. Until now, I didn't need to parse tooltips and I woud like to avoid it.
When you're trading with someone or sending items through mail, you can click one time on the virtual stack to give one stack, but if you try to click more times no more stack are traded or put in the mail frame. (In baggins with virtual stack you could click on the virtual stack as long as there was some items left on the virtual stack).
Can this be fixed? (If not can we have a button to temporarilly disable virtual stack)
That's too bad. I won't be able to use AdiBags in that case. :(
I added a quest item filter and rewrote the new item tracker, so these two points should be fixed.
Should be fixed in latest alpha.
I'm reusing Blizzard code, widget templates and bag/bank events at the most. Pushing an additional layer to handle "anywhere bank" in the current code would be a nightmare. Plus it would make AdiBags either too complex or too dependent of another mod.
No, I would need my bank categorized and laid out the same way everywhere. The categorization features are only useful if they can always be used. I unfortunately rely on seeing my bank everywhere far too much to lose it.
It's working perfectly
yesterday evening the behaviour was very strange:
equipment was no more divided in sets
palading blessing component (symbol of kings) which normally stack by 100, I had something lilke 306 symbol in my bags, virtual stack were activated but it was displayed as four stack (three stack of 100 and one stack of 6)
I've seen in the change log that incomplete stack should now be displayed in a separate stack (could it be possible to have an option to show incomplete stack in the virtual stack?)
Please check the settings of the item set filter.
Really strange. Could you print me the result of "/print GetItemInfo()"
Done.