while you were gone, many addons (VisualHeal, Grid, PitBull, sRaidFrames, PerfectRaid, BunchOfBars,...) switched to LibHealComm-3.0, which does not use RosterLib. While Grid does currently not display how much time is left on your Renews, it should be possible to add that functionality to a module. We'd just have to find someone to do so ;)
Good to hear =).
It isn't the amount of time left on the Renew that I was referring to, by the way. It was the square - with the HoT amount (like [563]) - on the raid frame that was nice. So for 15 seconds this square would be on the raid frame for each person I had put a Renew on.
Has there been any progress in this? I'm unable to update VisualHeal/HealComm to support battlegrounds when Roster-2.1 ignores the realm-part of the name.
Nope, it does not appear that there has been any progress with this. I'm still searching for a nice raid frame/healer addon combination. I simply don't have the time to do it myself, I apologize. Just returned from a long WoW break due to lack of time.
Before they added the suffix to players in battlegrounds the combination of sRaidFrames and IncomingHeals (uses Roster) was great. IncomingHeals left a square on the raid frame of everyone who I had placed a HoT on for the duration of the HoT. Inside the square it would have the amount that each tick of the HoT was doing. Visually, this meant I could very clearly see who I had already put a Renew on - very valuable in a big Alterac Valley battle.
I like Pitbull but the text does not stay on the raid frame for the entire duration... it ticks. This ticking behavior does not make it easy to quickly scan raid to see who is lacking a HoT from me.
Is there any way to customize the VisualHeal option? I'm not seeing anything besides enable/disable. (Looking for some basic things like being able to only see my own heals / HoTs keeping a permanent visual indication for their duration on the raid frame so I know I already have a HoT on that person).
How arduous would it be to keep a name-only to name-realm lookup table understanding that two players with the same name on different realms could cause conflicts (much like pets can do now)? Add that and post a diff. I'll give it a try and then commit it if nothing breaks.
Edit: Extend the existing *ByName api calls to allow for GetFooByName(name, realm)
I'm not seeing the value of the API allowing one to pass in the realm name if the uniqueness of the name is not guaranteed. In that case it seems like Roster-2.1 would just stay in its current form and any addons that use it would need to make sure they only pass names to the API - not name-realms.
Radon1, I'd like you to make those changes locally and run with several addons that use Roster-2.1 - like Detox, oRA2, BanzaiAlert, FuBar_GroupFu, Violation, and any other Roster-2.1 addons that you can find - for a few days, and then report back here how things worked out.
Greetings!
Unfortunately, my gaming time over the past couple weeks has been minimal and hence the amount of testing I've been able to perform has been minimal as well.
I loaded Detox, oRA2, and Violation. They "worked" locally on my own realm as far as I could tell just fine. Battleground-wise, the behavior that can be expected of any mod that uses my modified Roster-2.1 (read: cross-realm friendly) is as follows:
- If Blizzard events that pass a unit name are used in the addon they probably do NOT work with the released Roster-2.1 (like IncomingHeals - my quest to fix this addon led me to look at Roster-2.1 in the first place) cross-realm but work fine on the local realm.
They could work if they don't call any of the RosterLib API functions that have a unit name as a parameter, etc. If they do, they would pass in something like Bob-Sargeras and RosterLib would have that user indexed simply as Bob and would fail upon look-up.
- If Blizzard events that pass a unit name are NOT used in the addon they probably do work with the released Roster-2.1 cross-realm and on the local realm.
Neither the addon or Roster-2.1 would be cross-realm friendly in this case and would appear to work until you joined a Battleground with a player named Gandolf from Sargeras and a player named Gandolf from Maelstrom
Radon1, I'd like you to make those changes locally and run with several addons that use Roster-2.1 - like Detox, oRA2, BanzaiAlert, FuBar_GroupFu, Violation, and any other Roster-2.1 addons that you can find - for a few days, and then report back here how things worked out.
I've actually made the changes in my local copy of Roster-2.1 already.
As far as testing with addons that use Roster-2.1 goes, I've done some of this already with Ace-based IncomingHeals. The IncomingHeals addon and IncomingHealsLib library required similar UnitName() usage updates to fix. With only the Roster-2.1 updates, IncomingHeals still "worked." It just didn't fix the cross-realm issue until I updated it as well.
So, I'd be happy to run those other mods for a few days but ultimately any mods that use a player's name as an index need to use the Name-Realm format (note: if the player is on your realm there is no "-Realm" suffix) as this is the only way to guarantee its uniqueness and maintains consistency with the name argument passed by Blizzard events.
I'd like to request RosterLib be updated to be Battleground friendly.
In a nutshell all code like:
local name = UnitName(unitid)
should be replaced with code like:
local shortname, realm = UnitName(unitid)
local name = nil
if realm and realm ~= "" then
name = shortname .. "-" .. realm
else
name = shortname
end
Blizzard's UNIT_SPELLCAST_SENT returns the player's name in this Name-Realm format so it is important that any mods that use the player's name as an index also adhere to this format.
I'd be glad to make the changes myself if the people with access do not have the time.
I also have this Problem but only with Players from other realms (in bg). I see no incoming heals on the targets (not even my own) in sRaidFrames but in graph. For players of my reals ih works as intended.
Ah, I had been wondering why it would work for some targets and not for others. I wonder if this is an IncomingHeals issue or sRaidFrames issue? Or perhaps an issue with an interface lib they use in between?
I didn't realize how much I depended on this addon until it stopped working! It's very helpful when healing in AV - I know who I have HoTs on, etc.
Didn't see a topic for IncomingHeals so I created a new one.
I'm having issues seeing my incoming heals on sRaidFrames since updating for patch 2.2. Has anyone else experienced this? Sometimes it will show my heals, sometimes it won't.
0
Good to hear =).
It isn't the amount of time left on the Renew that I was referring to, by the way. It was the square - with the HoT amount (like [563]) - on the raid frame that was nice. So for 15 seconds this square would be on the raid frame for each person I had put a Renew on.
0
Nope, it does not appear that there has been any progress with this. I'm still searching for a nice raid frame/healer addon combination. I simply don't have the time to do it myself, I apologize. Just returned from a long WoW break due to lack of time.
Before they added the suffix to players in battlegrounds the combination of sRaidFrames and IncomingHeals (uses Roster) was great. IncomingHeals left a square on the raid frame of everyone who I had placed a HoT on for the duration of the HoT. Inside the square it would have the amount that each tick of the HoT was doing. Visually, this meant I could very clearly see who I had already put a Renew on - very valuable in a big Alterac Valley battle.
I like Pitbull but the text does not stay on the raid frame for the entire duration... it ticks. This ticking behavior does not make it easy to quickly scan raid to see who is lacking a HoT from me.
0
0
I'm not seeing the value of the API allowing one to pass in the realm name if the uniqueness of the name is not guaranteed. In that case it seems like Roster-2.1 would just stay in its current form and any addons that use it would need to make sure they only pass names to the API - not name-realms.
0
Greetings!
Unfortunately, my gaming time over the past couple weeks has been minimal and hence the amount of testing I've been able to perform has been minimal as well.
I loaded Detox, oRA2, and Violation. They "worked" locally on my own realm as far as I could tell just fine. Battleground-wise, the behavior that can be expected of any mod that uses my modified Roster-2.1 (read: cross-realm friendly) is as follows:
- If Blizzard events that pass a unit name are used in the addon they probably do NOT work with the released Roster-2.1 (like IncomingHeals - my quest to fix this addon led me to look at Roster-2.1 in the first place) cross-realm but work fine on the local realm.
They could work if they don't call any of the RosterLib API functions that have a unit name as a parameter, etc. If they do, they would pass in something like Bob-Sargeras and RosterLib would have that user indexed simply as Bob and would fail upon look-up.
- If Blizzard events that pass a unit name are NOT used in the addon they probably do work with the released Roster-2.1 cross-realm and on the local realm.
Neither the addon or Roster-2.1 would be cross-realm friendly in this case and would appear to work until you joined a Battleground with a player named Gandolf from Sargeras and a player named Gandolf from Maelstrom
0
I've actually made the changes in my local copy of Roster-2.1 already.
As far as testing with addons that use Roster-2.1 goes, I've done some of this already with Ace-based IncomingHeals. The IncomingHeals addon and IncomingHealsLib library required similar UnitName() usage updates to fix. With only the Roster-2.1 updates, IncomingHeals still "worked." It just didn't fix the cross-realm issue until I updated it as well.
So, I'd be happy to run those other mods for a few days but ultimately any mods that use a player's name as an index need to use the Name-Realm format (note: if the player is on your realm there is no "-Realm" suffix) as this is the only way to guarantee its uniqueness and maintains consistency with the name argument passed by Blizzard events.
0
I'd like to request RosterLib be updated to be Battleground friendly.
In a nutshell all code like:
local name = UnitName(unitid)
should be replaced with code like:
local shortname, realm = UnitName(unitid)
local name = nil
if realm and realm ~= "" then
name = shortname .. "-" .. realm
else
name = shortname
end
Blizzard's UNIT_SPELLCAST_SENT returns the player's name in this Name-Realm format so it is important that any mods that use the player's name as an index also adhere to this format.
I'd be glad to make the changes myself if the people with access do not have the time.
Thanks for your time and for this great library!
0
Ah, I had been wondering why it would work for some targets and not for others. I wonder if this is an IncomingHeals issue or sRaidFrames issue? Or perhaps an issue with an interface lib they use in between?
I didn't realize how much I depended on this addon until it stopped working! It's very helpful when healing in AV - I know who I have HoTs on, etc.
0
I'm having issues seeing my incoming heals on sRaidFrames since updating for patch 2.2. Has anyone else experienced this? Sometimes it will show my heals, sometimes it won't.
Thanks