Authors CurseForge

Quote from Taryble

You can't "break" MyMedia - if you get it wrong, you just (still) don't have access to the image/font.

You also have to copy the font (or make a symbolic link) into the addon.

Actually for fun once I modified my addon install script to update SharedMedia to have a bunch of links to all the activated fonts on my system. Surprisingly it worked okay until I hit an addon with a font selection dropdown that tried to show all the available fonts. As you can imagine (and as I expected) WoW crashed pretty quickly when trying to do that. Not sure if it was a bug in one of the fonts (not that unusual thing), a bug in the renderer (consider the crash trace I got this is actually a possibility), or just too much memory used (I do have a large number of CJK fonts with variant glyphs and advanced opentype support). I wonder how the WoW renderer would handle something like Studio Lettering.

So yes you can break MyMedia if you try. ;)

What happens if you move the Baggins.lua SavedVariables file aside and try logging in? Wonder if it's related to a specific filter. Are you running with any of my LibFilter plugins? Try disabling that if you haven't.

Not seeing any problems myself. Have you tried with just Baggins and no other addons installed?

Alpha r40 of LibFilter-1.0 has a quick and dirty implementation of Equipment Manager support. I still have to see how to works with items that are in sets but no longer in the characters possession.

Nice, I already have a filter by equipment slot as part of LibFilter, and a different one that takes equippablilty into account. While they can be combined, I might look at that function, but I'm hoping to allow my filters to work even for items that the player does not have. For example when used with Combuctor and looking at the equipment held by an alt. The biggest thing that worries me about the equipment manager API is I haven't found functions that return item strings for missing items yet. For example think of an account bound item as part of an set that is currently being used by an alt.

I've got some thoughts for a redesign (aka LibFilter-2.0) taking into account some of the limitations I've hit with my design when porting it to other Bag addons such as Combuctor.

That is my plan. I haven't hopped over to the PTR yet to find out exactly what I need to do, but hopefully shouldn't be that hard to implement.

Notes for myself:
EVENT is: EQUIPMENT_SETS_CHANGED (after VARIABLES_LOADED)
Also might need to track: BAG_UPDATE / UNIT_INVENTORY_CHANGED / BANK_OPENED
num = GetNumEquipmentSets()
name,texture = GetEquipmentSetInfo(i) 1 <= i <= num
set = GetEquipmentSetLocations(name)
slot = INVSLOT_FIRST_EQUIPPED ... INVSLOT_LAST_EQUIPPED
not set[slot] == ignored
== EQUIPMENT_SET_EMPTY_SLOT = ignored (as far as my stuff is concerned)
== EQUIPMENT_SET_ITEM_MISSING = ignored (as far as my stuff is concerned, might imply need to check bank events.)
player, bank, bags, slot, bag = EquipmentManager_UnpackLocation(set[slot])
itemID = GetContainerItemID(bag,slot) if bags
else
itemID = GetInventoryItemID("player",slot)

Quote from Elsia

In the end all this is pretty harmless for virtually any addon out there. Look, Blizz wants addons. It's added value. They go to great lengths to make the API extractable, accessible, they service an interface forum and they incorporate addon ideas they like and have broad use into their core game.

I agree that Blizzard intends to be reasonable about this, but still find it extremely distasteful, and that it's implications are harmful even if not enforced or enforceable. Which is why I'm am hopeful that Blizzard will tone it down a bit. I wish that they had dialogued more with the addon community for announcing this policy.

Quote from Elsia

After all the legal transaction there was that the author signed over his rights to FSF, so this is a matter between the author and FSF if anything.

Actually the GPL itself does not require the rights of the code to be handed off to the FSF. Some particular projects make that requirement, but the license itself does not.

Quote from Elsia

I think there is lots to rant about with GPL.

Completely agree which is why I will never use the GPL or LGPL myself for any project I create, and often go out of my way to re-implement the equivalent of any GPL code myself. But as you said off topic.

I wonder, assuming this is actually enforceable, does it cause section 12 "No Surrender of Others' Freedom." of GPL 3, (or 7 under GPL2, 6 under GPL1), to trigger for any addons and libraries under that license.

My biggest concerns are the service section under #1 (is curse premium client a service, what if a user offers to pay someone to code an addon even if it is to be openned source, consider various guild specific addons written for hire but released openly), #3 related to performance (I can understand the restrictions on chat stuff, but can see valid reasons for addons to temporarily impact performance, consider routes when it is asked to optimize the route), #5 (is it really that bad if an addon offers information about ways to support it as long as it isn't obnoxious) and #6 (Only thing I find more offensive then swearing, perversions, obscenities etc is censorship.). I understand what they are trying for I think, but the policy goes way overboard.

I wonder how many clicks, ad impressions, &c. these sites end up getting just from the negative attention. Won't be surprised if some of them started doing tricks like even letting some addon authors know that they 'rehosted' their stuff just so their links would get spread around and increase their search hits. Not to mention all the other authors that then start browser the site around looking to see what they can find.

Quote from lilsparky

Quest.Raid.Horde/Alliance/Both = "QuestID"
Quest.Group.Horde/Alliance/Both = "QuestID"
Quest.Daily... etc.

How about something like:

Quest.Raid.HordeOnly = "QuestID:minlevel:questlevel:choice1xcount;choice2xcount:rewardxcount...,QuestID..."
Quest.Raid.AllianceOnly = "QuestID..."
Quest.Raid.Both = "QuestID..."
Quest.Raid.Horde = "m,Quest.Raid.HordeOnly,Quest.Raid.Both"
Quest.Raid.Alliance = "m,Quest.Raid.AllianceOnly,Quest.Raid.Both"
Quest.Raid.All = "m,Quest.Raid.HordeOnly,Quest.Raid.AllianceOnly,Quest.Raid.Both"
and the same for Group and Daily... then

Quest.Horde = "m,Quest.Raid.Horde,Quest.Group.Horde,Quest.Daily.Horde"
Quest.Alliance = "m,Quest.Raid.Alliance,Quest.Group.Alliance,Quest.Daily.Alliance"
Quest.Both = "m,Quest.Raid.Both,Quest.Group.Both,Quest.Daily.Both"
Quest.All = "m,Quest.Raid.All,Quest.Group.All,Quest.Daily.All"

The syntax m,set,set,set.." means that set is expanded to contain the contents of all the listed sets.

Another option if the size of the quest data is large is to split it into 3 groups.

QuestHorde.Raid = "..."
QuestAlliance.Raid = "QuestID..."
QuestBoth.Raid = "QuestID..."
Quest.Raid.Horde = "m,QuestHorde.Raid,QuestBoth.Raid"
Quest.Raid.Alliance = "m,QuestAlliance.Raid,QuestBoth.Raid"
Quest.Raid.All = "m,QuestHorde.Raid,QuestAlliance.Raid,QuestBoth.Raid"
and the same for Group and Daily...

The advantage of the later approach is that QuestHorde, QuestAlliance, and QuestBoth can be split into separate LoD addons, but it's not as clean.

For LibStubLoader why not use: (dry coded)

package.loaders[#package.loaders+1] = function(lib)
  package.loaded[lib] = LibStub and LibStub:GetLibrary(lib,true)
  return package.loaded[lib]
end

Has the advantage that it doesn't need to iterate the libraries, and doesn't error if LibStub is not present.

Also LuaModules.lua has a bug where dbg is not defined if the package strips out the debug section. Either the calls to dbg need to be bracketed by the same, or dbg needs to be an empty function when that code is stripped.

I can see the value of something like this for bringing in 3rd party non-WoW specific lua code, but it losses some of the advantages that LibStub has with respect to versioning, when working with embedded modules. Modules will have to take care of there own versioning and only the first version defined will get to choice what functions are applied to the package table.

Quote from lilsparky

okay, so i think the data is complete. should is push my files thru the svn or is there a different way to have somebody verify it's cool first? also, i decided to go with "/" instead of "#".

There are a few other sets (TradeskillResultMats, Tradeskill.Gem.Cut, Reputation.Turnin) already using ";" to separate values so it might be the better choice for consistency. Also "/" is also already used for to mean "per" in other sets. For example 300 rep per 5 items turned in might be written as 300/5.

I see part of the problem at least with gems, not sure on the full 70 vs 80 gear stuff yet. Looks like it has a 2.3 and 2.4 gem list built in and checks the minor version to decide what to use. (See Data_Jewels.lua). Since 0 is not 4 it's probably using the 2.3 list. Wonder if there might be a way to get it to use LibPeriodicTable-3.1 "Tradeskill.Gem.*" instead. Would also need to get the enchant id's, which would be nice to have as the values for those sets, and seems like some of the code is based on the gem names.

Guess I never committed tag 2008-11-15. I just renamed my tag and submitted as 2008-12-05.

The loading text should not be present in the most recent versions. If you are still seeing it let me know which plugin and which version you are using. Thanks.