• 0

    posted a message on Skillet - Official Thread
    Quote from Terak »

    something at random

    [2007/10/17 16:39:11-6-x2]: Skillet-1.9-52204\UI\MainFrame.lua:890: attempt to index local 's' (a nil value)



    I looked into this and it appears to be one of those "this problem can never possibly happen" problems. When you say "at random," could you let me know how often it happens and if there are any particular tradeskills or recipes that seem to trigger it more often?

    Also if it happens again with a newer download of Skillet, could you put in the list error message?
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from Halgrimm »

    The only problem i have seen so far is that sometimes there seems to be a phantom old tradeskill window. For example i click on a tradeskill button and skillet opens up, then if i ctrl-click to view some item in the dressing room window, the dressing room will pop up in the middle of my screen as if there was still an old tradeskill window to the left of it.


    I've logged this as http://jira.wowace.com/browse/SKL-11, and I'll look into it tonight. Or maybe tomorrow :)

    Edit: tried to reproduce this and could not. I'll keep an eye out for it though.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from Saroz »

    Put potions into your own groups, like ATSW can do. So you can group up common pots you make.


    Ahhh, custom groups. I'm planning on adding this feature, but I probably won't be able to get it into this release. I used it myself when I was using ATSW. Comes in quite handy.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from Runkel »

    Love that addon, but i got a error when i try to open my trading skill window:

    - FIXED -

    Everything is fine now :) :)


    There are some very nice and very helpful folks that are helping out on translations on many mods, and they often catch the errors I make with translation code I can't effectively test. In this case, the credit goes to 'stan'.

    Ya stan!
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from lilsparky »

    along the lines of plugin development, i know you're planning on doing sorting. it would be swell to work out a system to register sorting routines in some fashion. for example, if lilsparky's workshop could plug into the sorting mechanism to allow sorting by reagent cost (or profit or whatever). other addons could do sorting by rep requirements for purchase or whatever might come up.


    Yeah, pluggable sorting should be easy. I'm going to restrict it to one sort method active at a time, just to keep my head from exploding, but aside from that you'll be able to sort any way your heart desires. Well, any way that someone is willing to write the code for at a least ...
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from Evenue »

    Once I finish ironing out some bugs with TradeskillInfo that I unwittingly created by adding a ton of recipes to it, I'm planning on adding a plugin to TSI (which mostly works with Skillet already) that will have a small window that lists only unknown trade skill recipes (per char), and where to obtain them (even if you have to farm it).

    Edit: If nogudnik wants to integrate this though, I'd be more than happy to share the database i'm still working on that has a list of where everything drops :)


    I like the idea of integrating this, but I don't think I'm going to have the time to do it in the next couple of weeks. What I'm hoping to do is get Skillet to a point where it would be easy to add this kind of functionality as a plugin module. Either as part of Skillet or as a separate mod.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from Saroz »

    The only thing I miss it the feature to make groups of potions, would REALLY like this... otherwise, uber mod.


    I'm not quite sure what you mean here. You should be able to queue up any combination of potions you want. Is that not working for you or were you looking for something more?
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from SaberHawke »

    Can you make the shopping lists not show if they are empty? If this option exists, I haven't found it.


    They're not supposed to show up if they're empty :(. It's a bug that I'm working on right now.

    Edit: Fixed. Empty shopping lists should no longer show up
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from Pook »

    Would it be possible to make a change to how Skillet handles the making of Oils (Wizard & Mana) by enchanters, So it is possible to make multiple items at once (as with other tradeskills)

    Its possible this has not been done for some reason, as ATSW also had this feature missing.


    It is possible, it's just a bit of pain. The Blizzard call to actually create the oil is DoCraft() and that does not allow you to specify any repeats, so I'd have to handle the repeat code myself. Not a huge problem, but a bit annoying.

    The other problem is detecting whether or not it is an enchant or an oil. I'm not sure how to do that except by checking the name and that means it has to be localized to all sorts of languages. Again, not impossible (or even hard) just a pain.

    Let me ponder this for a bit and see of I can come up with a way to do this that will not be an impossible to maintain hack.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from slyderz »

    Cooldown isn't showing for Nexus Transformation


    OK, I'll look into this tonight. Thanks for letting me know.

    Edit: Checked in a possible fix. Hard to test as I don't have any Nexus crystals handy to test with
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from bloodstrike »

    Make the Window resizable (couldn't for the life of me do this, not sure if I'm just dumb or you can't right yet


    Checked in code the enable this late last night :)

    Option for setting the transparency of the window - There is a lot of information there and sometimes takes up a lot of real estate on the screen and I can't see where I'm flying ;)


    I've had a couple of requests for this and it should be fairly easy. I'll see what I can do about getting it into the config for the next release.

    Option to turn of the 'bank' number - instead of ['number you can make now'/'number you can make with the stuff in your bank'] just ['number you can make now']. Most cases I don't keep mats in the bank (alchemy) but I can see why people would, so a checkbox for this would be awesome.


    Sounds reasonable. I'll see what I can do about it. Might not make it into the next release though.

    In ASTW, after you set up a queue of items and hit 'start queue', the start button was changed to a 'continue queue' button. Completely graphical in nature, but makes it a bit more understandable on what's going on for people that have never used ASTW


    Yeah. I'd already planned to do this, it just keeps getting pushed aside for bug fixes and new features. I am going to get it in there someday though. Really. Any day now.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from Terak »

    getting this error after update

    [2007/10/11 10:14:12-414-x14]: Skillet-1.9-51688\ThirdPartyHooks.lua:223: attempt to call global 'Skillet_GetExtraItemDetailText' (a nil value)


    Sorry. Accidentally left in a call to a function that got removed. I've just checked in a fix for this.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from Nevyr28 »

    Any way to get TSIs ability to show what level a recipe will go yellow,green,and grey to work with skillet?


    With the changes I made to Skillet tonight, TSI should be able to hook into it and display the info quickly cleanly. Here's some example code that can be added to TSI to do this:

    function TradeskillInfo:GetExtraItemDetailText(something, tradeskill, skill_index)
      local skillName, skillType, numAvailable, isExpanded = GetTradeSkillInfo(skill_index);
      if ( skillType == "header" ) then return end
      if ( skill_index > GetNumTradeSkills() ) then return end
    
      local link = GetTradeSkillItemLink(skill_index);
      local itemId = getIdFromLink(link)
      local text = nil
    
      if self:CombineExists(itemId) then
        if self:ShowingSkillProfit() then
          -- Insert item value and reagent costs
          local value,cost,profit = self:GetCombineCost(itemId);
          text = string.format("s: %s - c: %s = p: %s",
            self:GetMoneyString(value), self:GetMoneyString(cost), self:GetMoneyString(profit));
        end
        if self:ShowingSkillLevel() then
          local sep = ""
          if text then sep = "\n" else text = "" end
          text = text .. sep .. self:GetColoredDifficulty(itemId)
        end
      end
    
      return text
    end
    
    function TradeskillInfo:HookTradeSkillUI()
      if TradeSkillFrame and not self:IsHooked("TradeSkillFrame_SetSelection") then
        self:SecureHook("TradeSkillFrame_SetSelection");
      end
    
      if Skillet and not self:IsHooked(Skillet, "GetExtraItemDetailText") then
        self:Hook(Skillet, "GetExtraItemDetailText")
      end
    end


    I'm attaching a quicky picture of what the above code does.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from Evenue »

    TSI seems to work well enough with Skillet - I'll just need to do a couple of tweaks to TSI to get it to recognize the Skillet frame.


    I'm quite keen to make Skillet easy for other mod authors to hook into. Take a look at the file Skillet/ThirdPartyHooks.lua and if there is functionality/information that you'd like to see there, please let me know. I'm hoping that I can get a stable list of routines in there so that no matter how crazy I get in the future, I won't break compatibility with other mods.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - Official Thread
    Quote from fred »

    Very true Seerah....you are so wise. Or maybe I should have had a second cup of coffee before posting :)


    Indeed, Seerah is wise.

    I'm liking the look of that LilSparky's Workshop a lot. I'll do all I can to try and make it easy for the author to hook into Skillet as well.
    Posted in: General AddOns
  • To post a comment, please or register a new account.