• 0

    posted a message on ItemBonusLib, an Ace2 version of BonusScanner
    FYI : Base Haste rating for level 60 have been changed in the latest patch. The correct value for level 60 is now ~=10 (10.000001). You may want to update the CombatRatingMap accordingly.
    Posted in: General AddOns
  • 0

    posted a message on ItemBonusLib, an Ace2 version of BonusScanner
    Quote from Xinhuan »

    My addon GemHelper (available on WoWi) does indeed have such a table for users to search for gems, by colour, material, stat, source, etc.


    It does indeed. Amazing work there Xin, I wasn't aware of the existence of such an addon.

    Hopefully, there are far easier ways to determine the (empty) slots of an item.


    Yes, empty sockets are not much of an issue, since you can easily determine their color, it's socketed ones that are a pain, unless you can somehow map them.

    No, it has a impact on the value of the armor of items in bear form for druid.


    I have to apologize there, since you are totally right, seems armor kit bonuses are applied after the 400% of item armor.
    Posted in: General AddOns
  • 0

    posted a message on ItemBonusLib, an Ace2 version of BonusScanner
    You could (in theory at least) create a giant table (or tables) mapping every kind of gem to a specific color but it goes without saying that it would require an enormous amount of work (not only to create but also maintain). Not very practical, just to achieve a simple check for a meta gem.

    As for the bonus matter, it's a bit more complicated than that. You also have armor bonuses from weapons (eg feral staves), rings and trinkets to consider. In most cases what should and shouldn't be attributed to base or non-base armor is a matter of opinion.
    Posted in: General AddOns
  • 0

    posted a message on ItemBonusLib, an Ace2 version of BonusScanner
    Quote from Jerry »

    I have split the ARMOR bonus into BASE_ARMOR and ARMOR_BONUS. I hope it works, although I think there are cases where it will fail. I have added some code to return ARMOR as BASE_ARMOR+ARMOR_BONUS, to keep as much compatibility as possible.


    Quite logical, however the problem with this implementation is to separate the base armor bonus in an item that also has a "+XXX Armor" enchant on it (or a set bonus that uses a similar pattern), unless of course you consider "Reinforced Armor" patterns as the only ones that need to be taken into consideration when calculating the ARMOR_BONUS.
    Posted in: General AddOns
  • 0

    posted a message on ItemBonusLib, an Ace2 version of BonusScanner
    Quote from Joanna »

    Hi folks,
    I'm wondering if it's at all possible to create a stats for casters which sums generic and school specific damage together, or if that would have to be accomplished by a secondary addon (ItemBonus_Fu is the one I'm using at the mo). It's great having access to the information this library provides on screen, but it's be a whole lot more useful for me (as a firemage) if it simply totted up all my applicable damage and gave me a single number. I had thought of just going into my ItemBonusLib.lua and changing the referents for Fire Damange (FIRE) and Arcane Damage (ARCANE) to just DMG, but then items such as the Spellfire set give inflated values, so I guess I'm asking if it's possible for the library to actively total (specific school) + (generic dmg/healing) which I can then call from my other addons.
    Thanks for your time, and the great work, and my apologies for the somewhat garbled structure of my question.


    I guess an easy way to do that would be to have every relevant, generic dmg/healing pattern add its value to all the specific school damage subcategories as well, however this would have the side effect of not being able to distinguish "pure" school damage by directly calling the library.

    Another way would be to define new total school damage bonus categories (also keeping the present ones), eg 'TOTALARCANEDMG', 'TOTALNATUREDMG', etc and again modify the patterns so that generic dmg is being added to these as well as specific school patterns adding their values to their respective category.

    Too much of a hassle if you ask me, when you can easily call the library for the 2 separate values and add them in your addon to produce the desired result.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Interface\Addons\DrDamage\Data\Druid.lua: 36
    attempt to index global 'calculation' (a nil value)


    This error appeared to me yesterday for the first time when I tried to equip a T5 piece that activated the 4 set bonus (+150 healing to the lifebloom "bomb"). After that the tooltip in lifebloom on the bars wouldn't appear anymore and would trigger the same message each and every time I hovered over it. Any help would be appreciated.
    Posted in: General AddOns
  • 0

    posted a message on oRA2
    Quote from Astaldo »

    [2007/06/28 21:11:13-2104-x1]: oRA2\Options.lua:103: attempt to index global 'mod' (a function value)
    Dewdrop-2.0-42066 (oRA2):1791: in function <...terface\AddOns\oRA2\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1759>
    Dewdrop-2.0-42066 (oRA2):2695: in function <...terface\AddOns\oRA2\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:2654>
    Dewdrop-2.0-42066 (oRA2):2911: in function `Open'


    I'm getting the exact same error when trying to either open the oRA2 menu from the tooltip or when entering/exiting combat and when you are in the middle of a raid, it's sure annoying. It used to affect MT targets for me as well and had to request a status check to get them to appear.
    Posted in: Raid AddOns
  • 0

    posted a message on ItemBonusLib, an Ace2 version of BonusScanner
    Quote from Jerry »

    Quote from Rabbit »



    Is that useful?


    One last question... Did the text line of the complete socket bonus (+4 spell crit rating here) change when the bonus become active or just the text color ? What if you socket an gems of an incorrect color ? Does the text simply stay gray or turn red ?



    Color changes to indicate that the bonus is active after all gems are in place, so detecting the bonus via color change might be possible. A more "safe" suggestion is to detect if there are empty sockets on the item (in which case the bonus wont fire up). In such a case the empty sockets will just appear as "<Color> Socket" where color is Yellow, Red, Blue or Meta (for meta gems). It shouldn't be hard to parse each line of the tooltip via generic patterns and add the ones supported
    in TBC. Here's a small list of Gem bonuses as they appear in several incantations.

    -- TBC Patterns Generic/Gems/Sockets

    ["Spell Crit Rating"] = "SPELLCRIT",
    ["Spell Critical Rating"] = "SPELLCRIT",
    ["Spell Critical Strike Rating"] = "SPELLCRIT",
    ["Critical Strike Rating"] = "CRIT",
    ["Crit Rating"] = "CRIT",
    ["Spell Penetration"] = "SPELLPEN",
    ["Defense Rating"] = "DEFENSE",
    ["Mana per 5 Seconds"] = "MANAREG",
    ["Mana every 5 Sec"] = "MANAREG",
    ["Mana every 5 seconds"] = "MANAREG",
    ["mana per 5 sec."] = "MANAREG",
    ["Dodge Rating"] = "DODGE",
    ["Parry Rating"] = "PARRY",
    ["Resilience Rating"] = "RESILIENCE",
    ["Melee Damage"] = "DMGWPN"

    on top of this you have :

    ["Resilience"] = "RESILIENCE",
    ["Hit Rating"] = "TOHIT",
    ["Spell Hit"] = "SPELLTOHIT",
    ["ranged Attack Power"] = "RANGEDATTACKPOWER"

    but those are not limited to gems anyway.

    Meta gems also provide special secondary bonuses (e.g. chance to proc X effect) but most if not all aren't really countable.

    To the best of my knowledge you cannot socket incorrect gems.
    Posted in: General AddOns
  • 0

    posted a message on ItemBonusLib, an Ace2 version of BonusScanner
    Quote from Skulli »

    well for me itembonusesFu is only adding the 55healing from the enchant when i equip the staff. no 62 from the aura or 300 from itself.


    True. I think I encountered the same problem initially and then I simply switched the order of the patterns by editing the lib (moving the aura pattern above the 120 dmg and 300 healing) and then it would parse it properly. Jerry should be able to provide with a better (and more permanent) solution.
    Posted in: General AddOns
  • 0

    posted a message on ItemBonusLib, an Ace2 version of BonusScanner
    Quote from Jerry »


    Quote from Minada »

    It seems like Atiesh priest version bonuses are not detected (+120 dmg & +300 healing, +62 healing from aura).


    Already reported. I have no idea why, as the pattern is there. Could someone try to change the line "local DEBUG = false" to "local DEBUG = true" in ItemBonusLib.lua and make a screenshot of the output of the scan for Atiesh, it might help a bit.



    The 62 healing from aura is ok as far as I can tell (and tested) :

    pattern = "Increases healing done by magical spells and effects of all party members within %d+ yards by up to (%d+)%.", effect = "HEAL"

    However, since spell dmg and healing benefit are not THE SAME on the pattern :

    pattern = "Increases your spell damage by up to (%d+) and your healing by up to (%d+)%.", effect = {"DMG", "HEAL"}

    the addon will calculate the first bonus located (in our case spell dmg) as the healing effect as well (probably cause the pattern assumes that both values are identical but this is not the case here). Thus it will provide a healing bonus of 62+120=182 instead of 62+300=362.

    Moreover for the Atiesh, mage version :

    pattern = "Increases the spell critical strike rating of all party members within %d+ yards by (%d+)%.", effect = "SPELLCRIT"

    This is the correct pattern to the best of my knowledge and not "Increases the spell critical chance".
    Posted in: General AddOns
  • 0

    posted a message on ItemBonusLib, an Ace2 version of BonusScanner
    Not yet but I will be checking it once I get home from work (:P) and run a few tests with various items, while also evaluating more tooltips.
    Posted in: General AddOns
  • 0

    posted a message on ItemBonusLib, an Ace2 version of BonusScanner
    The current patterns used for tooltip detection in ItemBonusLib need a lot of work and it's pretty much the same deal for every other addon I've seen so far in 2.0 including Bonus Scanner and a few others, however most of the changes seem to be global.

    First thing to notice in tooltips for spell crit and some other formulas is that the "Improves your chance to get a critical strike with spells..." has been changed to "Increases your chance to get a critical strike with spells...". Feral AP has been completely reworked. The correct formula now should be :

    { pattern = "Increases attack power by (%d+) in Cat, Bear, Dire Bear, and Moonkin forms only%.", effect = "ATTACKPOWERFERAL" }


    Next we move on to healing enchants, ["Healing"] = "HEAL" needs to be added to the Generic patterns (eg to detect +XX Healing). Most importantly, armor kits have changed entirely. Tooltip will now display like this :

    "Reinforced (+XX Armor)" where XX is a value according to the kit used. I have tried to locate a proper pattern but I was mostly banging against a wall.
    Posted in: General AddOns
  • To post a comment, please or register a new account.