• 0

    posted a message on Addon comms changes
    It seems this issue is still a problem somehow. A guild member and me were in Orgrimmar and we both have the same (my) addon loaded that communicates using the guild addon channel. When he ported to Tol Barad, apparently a guild addon message was lost/deleted by the client/server (not by the addon). Or is the addon channel known to be lossy? I never experienced this using the chat channels (which I may just revert to if this is to be expected). :-/
    Posted in: Lua Code Discussion
  • 0

    posted a message on Detecting update of tradeskills
    What would be the most efficient way to detect if the player has just learned a new recipe?

    Is it listening to CHAT_MSG_SYSTEM when arg1 looks like ERR_LEARN_RECIPE_S (eg. "You have learned how to create a new item: Bristle Whisker Catfish.")

    or is there a better way?

    When the event occurs, I'll read the updated tradeskill link and continue from there. I don't need to know the recipe learned from the event.
    Posted in: Lua Code Discussion
  • 0

    posted a message on Read guild tradeskill links
    Is it possible to gather the tradeskill links from all players in the guild you are in? I can't seem to find the API for it.
    Posted in: Lua Code Discussion
  • 0

    posted a message on Max lines in tooltip?
    I think I am referencing invalid item:* links (as they are provided by LibPeriodicTable) and asking wow to fetch the tooltip. But I thought fetching invalid items wouldn't crash wow. Worst I'd expect to be disconnected...

    But the client crash occurs after my code has enumerated all the links (extracted name and quality info) and wow often manages to display the tooltip before actually crashing. This strengthens my suspicion that something is corrupting wow's memory, causing a delayed crash. I can only hope Blizzard puts in better API parameter verification... :-P

    For now I have worked around it my using GetItemInfo directly instead of using a mix of GetItemInfo(itemlink) and tooltip:SetHyperlink(itemlink) to get item and enchant information (as this can crash wow).
    Posted in: Lua Code Discussion
  • 0

    posted a message on Max lines in tooltip?
    I have now tried to isolate the bug only to have the bug vanish on me. I am now running my original addon (the one that triggered the crash) and I cannot reproduce the crash. I can only consider some wow API or its Lua interpreter to malfunction in some exotic way. :-/
    Posted in: Lua Code Discussion
  • 0

    posted a message on Max lines in tooltip?
    Well, I spoke (wrote) too soon... even with a 100 (then 75 and then 25) limit, WoW crashes. I'll have to debug this more heavily than I originally hoped.
    Posted in: Lua Code Discussion
  • 0

    posted a message on PeriodicTable-3.1
    The TradeSkill* section of the dataminer also needs a look-at. It does not include Cataclysm items. I'll try to see what is going on, but can't promise it'll be soon...

    Edit: It does seem to include Cataclysm data, it just hasn't been committed yet...
    Posted in: Libraries
  • 0

    posted a message on Max lines in tooltip?
    Well, while I do agree with your argument, artificially limiting the number of tooltip lines does avoid the crash. But my manually attempt isn't identical to the way the addon does it and the difference is basically that I manually opened the tooltip from the command line (using a macro).

    Anyway, I have successfully avoided any crash since I imposed the limit to the tooltip.
    Posted in: Lua Code Discussion
  • 0

    posted a message on Max lines in tooltip?
    Tried opening a tooltip manually and added up to 210 lines, but I got no crash. I tried repeated the steps I did in my addon (that does cause the crash) but interactivly, I can't reproduce the crash.

    Anyway, the crash has been avoided artificially limiting the number of lines to no more than 100 (should be enough for even the largest screens. :-P ).
    Posted in: Lua Code Discussion
  • 0

    posted a message on Max lines in tooltip?
    According to http://www.wowwiki.com/API_GameTooltip_AddLine there isn't a limit to the number of lines you may add to the tooltip, but I believe there is a limit. I have an addon that adds various amount of lines to a tooltip and when putting 210 lines into the tooltip, wow instantly crashes.

    I'll try to see if I can find a safe limit...
    Posted in: Lua Code Discussion
  • 0

    posted a message on Detect if my tradeskill window is opened
    Thanks. :)

    Do you also know which event to wait for before reading this information upon login?
    Posted in: Lua Code Discussion
  • 0

    posted a message on Detect if my tradeskill window is opened
    Quote from lilsparky

    personally, i would assume viewing a link of your own trade skill would be considered as not viewing your trade skill since it's likely the only reason you'd do so is to spoof a tradelink bitmap.


    I may have missed a new function or the change of an existing one, but is it possible to get all of the players tradeskill links without waiting for the craft window to be opened?

    I know about GetProfessions and GetProfessionInfo but they do not provide the link.
    Posted in: Lua Code Discussion
  • 0

    posted a message on Detect if my tradeskill window is opened
    I would like to know if the tradeskill window just being opened is showing my craft or not.

    I listen for the TRADE_SKILL_UPDATE event and previously I could use IsTradeSkillLinked() to help determine if the windows was showing my data or not, but this is not sufficient in Cataclysm.

    Any suggestions?
    Posted in: Lua Code Discussion
  • 0

    posted a message on Does AceComm protect the receiving end too?
    40 senders broadcasting every second? Everyone would receive 40 messages per second? Do I understand this correctly? If so, your addon would scale horribly. The messages being broadcast should probably contain information to reduce the need to broadcast continuously.
    Posted in: Libraries
  • 0

    posted a message on Does AceComm protect the receiving end too?
    How many senders would at most be active at any given time?
    Posted in: Libraries
  • To post a comment, please or register a new account.