• 0

    posted a message on design advice for a data scanning lib
    I would have no objections to having a seperate addon as a requirement to GuildAds, but GYP is a tad too big and the tradeskill grinding code is much smaller (about 20KB, a bit more with additional support functions).

    Reg. the scanning in the background, that would probably not work as the TradeSkill window is needed to perform the scan (as I understand it). However, if the data is in the local cache, I guess the scan could be reasonably fast. I take it you hint at simply not storing the gathered data at all?
    Posted in: Libraries
  • 0

    posted a message on design advice for a data scanning lib
    I am not following you...
    Posted in: Libraries
  • 0

    posted a message on LibCompress
    I have tagged a new release (rev42) yesterday but it hasn't shown up on curse.com yet. Isn't this automatic anymore? If not, what should I do to push things (besides this)? ;-)
    Posted in: Libraries
  • 0

    posted a message on design advice for a data scanning lib
    If adding GYP ended up being the solution, I'd only have 2 issues:

    1) I already programmed GuildAds to use the LibTradeLinks API but if GYP is similar (haven't checked) that would be easily fixed.

    2) GYP is 500KB in size whereas LibTradeLinks (14KB code+73KB table)+GYP scanning code (19KB) is approx. 106KB in size. I find this to be a significant difference in size.

    Due to size alone, I prefer to be able to include only the scanning code (as modified by OrionShock).

    What would be the problem if the scanning code would be placed in a library with instructions that it cannot be embedded (due to need of saving the data)?

    Or what happens if multiple addons all have the same variable they want to save? I assume saving would be working (except for multiple copies on disk) and loading would load all saved copies but only the last one loaded would be in memory (which shouldn't matter, right?).
    Posted in: Libraries
  • 0

    posted a message on PeriodicTable-3.1
    Just to be sure, when the lua files says:

    $Rev: 139 $


    , will the svn-keywords "Revision Date Id" trigger on that or should we correct the lua code to:

    $Revision: 139 $
    Posted in: Libraries
  • 0

    posted a message on PeriodicTable-3.1
    Just checked the files and they already had svn-keywords on, but not the right ones:

    Revision Date Id (most have this)
    Revision Date (1 has this)
    (1 is missing svn-keywords altogether)

    I didn't know about svn-keywords so thanks for the pointer. :-)
    Posted in: Libraries
  • 0

    posted a message on PeriodicTable-3.1
    I just noticed that there seems to be a slight detail missing (if I read it right) in the guides regarding updating the files.

    It says that updating the result files manually is futile as they get overwritten by compresssplit.lua. This is not entirely true. This line:

    LibStub("LibPeriodicTable-3.1"):AddData("TradeskillResultMats", gsub("$Rev: 139 $", "(%d+)", function(n) return n+90000 end), {


    has to be manually updated as the revision number must be increased. If this is not done, the new data will not be loaded if an old revision is already loaded. This is only possible by editing the result files directly as compresssplit.lua doesn't update these lines.

    Question is, should we update the number by increasing by one or to the current (non-committed) revision or guess the revision number we end up committing to and put that number in?
    Posted in: Libraries
  • 0

    posted a message on PeriodicTable-3.1
    Quote from galmok
    Already did. Once they react to it, I'll commit the changes from the latest run of dataminer.lua and compresssplit.lua.


    I haven't gotten any response back from wowhead.com and I guess I wont be getting any either. They didn't fix the item classifications so I wonder how to fix them manually. I don't really understand the principle in the dataminer and compresssplit to put in the 7 misclassified ids. :-/
    Posted in: Libraries
  • 0

    posted a message on PeriodicTable-3.1
    Quote from jerry
    So ask wowhead to fix their DB, and it's gonna fix your issue.


    Already did. Once they react to it, I'll commit the changes from the latest run of dataminer.lua and compresssplit.lua.
    Posted in: Libraries
  • 0

    posted a message on PeriodicTable-3.1
    I have tried looking in the dataminer.lua for bugs, but there doesn't seems to be any (not that I was that thorough :-P ) but I started looking at wowhead's data from within firefox and focused on just item:32765 which is Earthstorm Diamond, crafted by Transmute: Earthstorm Diamond.

    The page that should hold all crafted alchemy items is according to dataminer.lua this:

    http://www.wowhead.com/?spells=11.171

    While it produces a long list of items, the Earthstorm Diamon is not amond them. Then I looked in the javascript embedded in the result page and found this:
    _[25867]={name_enus:'Earthstorm Diamond',quality:3,icon:'INV_Misc_Gem_Diamond_04'}So the item was mentioned in the g_items table, but the spell Transmute: Earthstorm Diamond is not listed in the g_spells table nor is it listed in the Listview table.

    I feel it should have been there, but am I wrong in thinking that? I could contact wowhead about this issue but will wait until I get a response here.

    Last thing I did was checking what wowhead actually had to say about Transmute: Earthstorm Diamond. It is located in the Database -> Spells -> Uncategorized section whereas the rest are located in the Database -> Spells -> Professions -> Alchemy.

    Looking at the other items in the uncategorized section makes me believe that Earthstorm (and the rest) are simply not classified correctly with wowhead.

    Anyway, my above question remains: Should I simply commit the updated data files to SVN?
    Posted in: Libraries
  • 0

    posted a message on PeriodicTable-3.1
    I am looking to update the tradeskill section of LPT as a lot of items are missing when trying to look up which item link an enchant:XX link crafts. These are the enchant id's that lacks their item id counterpart:

    64358,32765,32766,60969,60971,64727,64728,62941,64725,64726,63743,62948,62959,
    64661,44155,44157,64730,63742,64729,64054,64258,64259,64267,64260,64053,64261,
    64262,64266,62050,62051

    I have checked out the SVN copy of LPT (rev 168, latest) and run the dataminer and received an updated data.lua. I am not sure how to interpret the summary of dataminer which is as follows:

    Elapsed Time: 29m 52s
    29m 51s spent servicing 1390 web requests
    0m 1s spent in processing data
    Approx 29m 51.88s CPU time used
    616 sets mined, 1383 sets not mined.

    I am confused about the 1383 sets not mined. Is that just because no updates were necessary or did I miss something somewhere?

    Having an updated data.lua, I am not entirely sure what to do now. The Editing page says to run compressplit.bat, but there is no such file in SVN. There is a compressplit.lua, though, so I guess that is the file to run. Is it safe to pass no arguments? It seems to want to update all of LPT if I do.

    And once done, should I commit the result?

    I haven't yet checked if the updated tradeskill section has the missing data, but if it hasn't, what are my options?

    Edit: I checked the above list of enchant links and after updating, the list is reduced to these 6 enchant links that do not have an item id linked to it:

    32765,32766,60969,60971,44155,44157

    How do I add the missing information related to these id's?

    I reference the section :ItemInSet(link,"Tradeskill.RecipeLinks") but maybe that is too narrow? Can I reference it like "Tradeskill"? I'll try. :-P

    Edit2: Using "Tradeskill" instead of "Tradeskill.RecipeLinks" didn't help.
    Posted in: Libraries
  • 0

    posted a message on Finding the character linked to TRADE_SKILL_CLOSE
    Quote from LaoTseu
    IsTradeSkillLinked() in the TRADE_SKILL_CLOSE event is the way to go.

    Thanks for that lilsparky.


    Try that method with the addon Armory loaded and report back. Chances are it doesn't work...
    Posted in: Lua Code Discussion
  • 0

    posted a message on How to read tradeskill info reliably
    Quote from lilsparky

    also, i'm curious why you'd ever have it clear the list if you don't get any valid spells. is the generated list supposed to be dynamic or is it supposed to be a complete list of the all the items a person can produce? that list shouldn't ever get smaller unless the person unlearns a skill. but if they do unlearn it, there's an event that fires that you can look for.


    I clear the list because the list changes occasionally depending on what Blizzard decides to do with the items. Also, if GuildAds wasn't running when the item was unlearned, it would remain in the database and shared with every user until manually edited out of the database. The list is to be accurate. This would all be easier to verify if only there was a library that would give me the spell and item ids from the trade links. I am not really in the mood to gather all that data myself, but if I may have to do it myself.
    Posted in: Lua Code Discussion
  • 0

    posted a message on How to read tradeskill info reliably
    Quote from lilsparky
    you had mentioned some quirkiness between the close button vs the spell button. i think what's happening is that armory is hooking the close button to do some additional processing. that processing results in additional UPDATE events firing prior to the close. i have no clue why the author of armory did it that way. if you disable armory, you'll probably find that the close button reacts the same way as the spell button.

    You are probably right, but I would like my addon to work even with armory present and that means I have to work around the problems that Armory creates. :-/
    Posted in: Lua Code Discussion
  • 0

    posted a message on How to read tradeskill info reliably
    I need the item info really. GuildAds offers the view of every users tradeskill items/spells and allows to categorize them just like in the auction house. For that to work, I need to know the item id.

    Is there any pointer anywhere on how to take a spell id and get the item id using LibPeriodicTable? I checked the API but found no function that takes a spell id and returns the item id.
    Posted in: Lua Code Discussion
  • To post a comment, please or register a new account.