• 0

    posted a message on Getting guild info on login?
    I have had problem reading tyhe Guild Info page as well. GuildRoster() has an internal cooldown and sometimes, even when receiving the associated event, there was no Guild Information to be read. It is quite difficult to ensure you get usable data...
    Posted in: Lua Code Discussion
  • 0

    posted a message on LibCompress
    Well, honestly, curse.com has not exactly been in great shape itself quite a lot of times.

    Anyway, the rename stuff is also possible to convey using SVN so that argument fails. Basically you argument that SVN security must be increased, enforcing manual approval of every commit made.

    I'll just continue providing alternative download sites. At least I can do that without anyone doing anything about it.
    Posted in: Libraries
  • 0

    posted a message on LibCompress


    This zip-bomb technique would be worthless for a simple tool scanning suffixes of files as the files wouldn't be uncompressed at all. Also, since .zip wouldn't be on the allowed extension list in zip files, such a file would be automatically chosen for manual approval.

    No problem so far with the automatic approval idea.
    Posted in: Libraries
  • 0

    posted a message on LibCompress
    Quote from ciscoh
    i think the current methodology provides the most efficient, safest and developer oriented environment. i think asking for them to allow for every possible scenario is a little unreasonable


    I am just finding a good compromise. The current solution is not good as I have to provide links to alternative download sites.
    Posted in: Libraries
  • 0

    posted a message on LibCompress
    Quote from HunterZ
    That's what wowui.incgamers.net does, and it's turned into a game of cat and mouse between the site admins and malicious software creators. The last attack was something along the lines of an executable inside of a zip file, inside of another zip file, and their virus scanner wasn't smart enough to recursively extract.


    But that is why I said to check the extensions of the files in the zip file (or at least that is what I meant). If only lua, toc, wav, txt and other similar harmless files are in the zip, then automatically accept the file. Otherwise continue with the manual approval. If they can make that for SVN, zip should be no problem.
    Posted in: Libraries
  • 0

    posted a message on Querying the server for item info
    Quote from Arrowmaster
    It has never done that. It triggers once when the message is displayed saying its querying the info, and then it triggers again when (if) the tooltip is actually updated with the info. So you need to do self:GetItem() and check that it isn't nil to avoid your function being triggered on the first call if the item is not in the cache.


    Thanks. I didn't experience that behaviour (long time ago), though. But if that is how it works today, I'll have a look and redo the item fetching code in GuildAds (eventually... it does work now. :-P)
    Posted in: Lua Code Discussion
  • 0

    posted a message on Querying the server for item info
    Did they fix the OnTooltipSetItem event? Previously it triggered even when the item showed the message that it was waiting for item info (and didn't trigger once the item info was retrieved from the server). This is why GuildAds doesn't use the event (we did try it).
    Posted in: Lua Code Discussion
  • 0

    posted a message on LibCompress
    Well, then just implement a scanner for custom uploaded zip files. If only safe extensions, then no human intervention is necessary, same as SVN.
    Posted in: Libraries
  • 0

    posted a message on LibCompress
    Quote from Xinhuan
    Trojan, Viruses, etc.

    2 months ago, a malicious author uploaded 3 different zip files that contained a trojan to uiwow.incgamers.net, and it passed their automated virus scanning system. These addons were passed off as Omen, Curse updater and wowace updater.


    Is also possible via SVN... unless I am mistaken.

    Anyway, wow wont run the virus files so there shouldn't be any real problem.
    Posted in: Libraries
  • 0

    posted a message on LibCompress
    Anyway, posts and project pages are not delayed in update and I will just post links to alternate download pages. Takes away some of the enjoyment of writing addons for people, though. Maybe this is why other addons have been removed from curse.com, I don't know..
    Posted in: Libraries
  • 0

    posted a message on LibCompress
    But every page is controlled by a login and a list of authors. Wouldn't it be enough to whitelist the authors instead of whitelisting every single file?
    Posted in: Libraries
  • 0

    posted a message on LibCompress
    Wouldn't quite work as I have a script to generate a lua file from SVN which has to be included in the package. So a release of GuildAds is not just a zip-operation. :-/

    I can of course generate the file offline and commit it to SVN before each release, but that is also a bit cumbersome.

    I think I'll continue to upload the file as usual and provide an alternative download link.

    Any reason why the upload has to be approved by hand? Seems a bit stupid. :-/
    Posted in: Libraries
  • 0

    posted a message on LibCompress
    No thanks. I have experienced too many problems with curse.com to move guildads there. Maybe if I see 1 year of near-flawless operation... ;-) and then only if the SVN log/history can be preserved (I often have to go back to old revisions to check something).
    Posted in: Libraries
  • 0

    posted a message on Querying the server for item info
    We have had to handle this situation in GuildAds for a long time and have a fairly big algorithm to query item: and enchant: links, datamining the tooltips, checking for timeouts, and so on. One thing is sure: GetItemInfo will not disconnect you even when questioning hundreds of item links (after all, GetItemInfo only returns what is in the cache files). Setting the toolltip with SetHyperLink with hundres of known items in a row will also be fine (no server traffic is caused by this).

    But...

    Believe it or not, quering all enchant: links will cause a disconnect. Quering here means showing enchant tooltips one after another as fast as possible (when the client hasn't seen them before since the cache was cleared last). Once enchants are known, there is no server traffic involved anymore and tooltips can be retrieved as fast as you can show the tooltips.

    If you want ideas, have a look at GuildAdsItem.lua. It handles all item/enchant (and spell, although not completely verified) retrieval for the rest of GuildAds. The code is old but kept fairly up-to-date. Some of it can probably be done smarter now than it could years ago, but it works. :-P
    Posted in: Lua Code Discussion
  • 0

    posted a message on LibCompress
    It was my other addon, GuildAds, that I upload versions of manually. About 6 hours after I uploaded the file, it finally was available for download. In the future, I think I have to provide download links on sourceforge.net (where GuildAds SVN is hosted) as well. The latency on curse.com is just too annoying.
    Posted in: Libraries
  • To post a comment, please or register a new account.