• 0

    posted a message on RangeCheck
    Wow, lot of activity here lately :)

    I'll try to answer all the questions:

    First off, the wiki survived the big wipe:


    Quote from Mrs. Steele »

    I'd love it if you could incorporate this to work with ag_UnitFrames. The current mod RangeCheck_M only uses a default follow range (I believe) with no options to edit. If your lib can read my max range and fade out the unitframe when out of range, that would rock.


    It should be fairly trivial to add this feature to ag_UF, although there are usually 2 interesting ranges for healers: heal range (usually 40yd) and dispel range (usually 30yd), so a decision must be made which range should be displayed as graying out the UF. (checking for max range as you requested would be the easier way, though). Have you tried contacting the ag_UF author about this? I think it should be easier for him/her to do.

    Quote from KyesaRRi »

    Having a few problems with this on my lvl 67 Shadow Priest. Friendly spells work fine but whenever i target an enemy i get a static 40+ as the range which never changes.

    Screenshots:
    http://www.imagedump.com/index.cgi?pick=get&tp=508127
    http://www.imagedump.com/index.cgi?pick=get&tp=508128

    Edit: I have tested being in / out of combat, no change.


    Sounds like I used a spell in the range list that is not behaving as I expected (I couldn't test with all classes, unfortunately). The IsSpellInRange() call sometimes returns nil even though the spell is in range but it can't be cast due to some other limitation (for example, polymorph on a Dragonkin target), so there could be a mistake like this. Yep, found it, the problem is Mind Soothe. You can update RangeDisplay (or just RangeCheck-1.0, if you use standalone libs) from files.wowace.com and check if it's OK for you. The new release on WowInterface will be up shortly, too. Thanks for the bug report!

    cheers,
    mitch
    Posted in: General AddOns
  • 0

    posted a message on RangeCheck
    Yo,

    I renamed the GUI part to RangeDisplay. Also added an optional 100 yd range check (although I do it with UnitIsVisible() and not Hunter's Mark)

    Please report any issues.

    cheers,
    mitch
    Posted in: General AddOns
  • 0

    posted a message on RangeCheck
    Quote from mulesh »

    Can you add Hunter's Mark to the HarmSpells for HUNTER? I added it to my copy and got no errors. Thanks.


    Hi,

    I intentionally left out Hunter's Mark, as I thought the 40-100 yard range is kinda useless. If you can target the mob, it's most likely within 100 yards, and that range is just so large that it doesn't really tell any useful info. If you still think it's worth to put in, I can add it (together with priest's Mind Vision, probably).

    cheers,
    mitch
    Posted in: General AddOns
  • 0

    posted a message on Violation
    Hi,

    I think that simply placing the anonimous pet damage check a bit earlier solves the issue with the Water Elemental:

    Index: Damage/Damage.lua
    ===================================================================
    --- Damage/Damage.lua (revision 40360)
    +++ Damage/Damage.lua (working copy)
    @@ -51,6 +51,10 @@

    function mod:OnParserEvent( infoType, info, event )
    local source, victim, amount = self:GetSourceVictimAmount(info)
    +
    + if Violation:IsAnonymousPetEvent(event, info) then
    + source = self.playerName
    + end

    if not source or amount == 0 or not self:AcceptDataFor(source) then
    return
    @@ -65,9 +69,5 @@
    end
    end

    - if Violation:IsAnonymousPetEvent(event, info) then
    - source = self.playerName
    - end
    -
    self:OnData(source, amount)
    end
    Posted in: General AddOns
  • 0

    posted a message on Threat-1.0 and KTM comms
    Off topic, sorry, but the Threat-1.0 errors thread is locked for some reason...

    so, there's a nil reference at

    Threat-1.0/ThreatClassModuleCore.lua:712

    if I summon my Water Elemental while I have a fresh mob targeted.

    (self.targetThreat is nil)

    Revision: 40194

    cheers,
    mitch
    Posted in: Libraries
  • 0

    posted a message on RangeCheck
    I've separated the logic to RangeCheck-1.0 lib, and RangeCheck is now only the "presentation". RangeCheck-1.0 is done using closures now instead of "classes".

    cheers,
    mitch
    Posted in: General AddOns
  • 0

    posted a message on Violation
    Quote from ChaoticNeutral »

    Violation still doesnt merge pets with my damage ( my own water elemental )

    Which really sucks since i can see on sws that other people have it with me and pet merged, but i cant get violation to do teh same =(

    (Yes, merge pets is clicked)


    Tested this myself, too (last nights version, forgot to record the revision number). My WE's damage is not added regardless of "Merge Pet" setting.

    regards,
    mitch
    Posted in: General AddOns
  • 0

    posted a message on RangeCheck
    Thanks for the tips.

    Converting the addon to this style would probably make it a bit more readable, so I'll get onto it when I'll have some time. I'm especially happy about the gratuity stuff, I hated the fiddling with my own tooltip, it felt wrong.

    The friendly spell detection is also nice, do you have any idea how to do the same for hostile spells as well? I think that simply negating the condition would not yield correct results, but I'll try to test it. Hm, just noticed the API function IsAttackSpell(). I'll try playing around with it. Would be nice to get rid of any manual configuration.

    cheers,
    mitch
    Posted in: General AddOns
  • 0

    posted a message on RangeCheck
    Quote from Pastamancer »

    This isn't java. You might want to consider replacing most of your "classes" with closures.


    Well, the only place I really need a "class" if for the RangeCheck (abstract) class so that I can implement different behaviour in RangeCheckInteract and RangeCheckSpell (names might be off, but you get the point). I don't know how to do that without "classes".

    I'm fairly new to lua, and yes, I come from a c++/java world, so feel free to educate me

    cheers,
    mitch

    ps: besides, what are the actual benefits of using closures instead of "classes"?

    Posted in: General AddOns
  • 0

    posted a message on Violation
    Quote from Adirelle »


    Merged with the caster if and only if he is running Violation.


    Erm, how does it differenciate between 2 water elementals of 2 different mages in the same group?

    Also, should the WE show up on the list if I turned off "Merge Pet Data"? (I tried it and it didn't work)

    cheers,
    mitch
    Posted in: General AddOns
  • 0

    posted a message on RangeCheck
    Quote from Olivier Mayeres »

    It's nice, but why don't do library to integrate into a Unit Frames


    Hi,

    Converting it to be a lib should be straighforward, but

    a) first I want to make sure it actually works :)
    and
    b) I don't have any experience yet with writing ACE libs

    This could be used by other addons as-is, though, like:

    local range = RangeCheck and RangeCheck:getRange(unit)

    but there could be issues with this approach that I'm not aware of.

    I'll dig into this library stuff when I get some time. I'd like to integrate the range display in TinyTip as a first excercise.

    cheers,
    mitcyh
    Posted in: General AddOns
  • 0

    posted a message on RangeCheck
    Quote from Jakobud »

    Damn I was just making an addon similar to this.


    I'm sorry about that :) but the functionality was part of SpellCaster for a while now anyway, I just cleaned it up a bit and made it a separate addon.

    cheers,
    mitch
    Posted in: General AddOns
  • 0

    posted a message on Violation
    Hi,

    Is there a way to turn on display for the Water Elemental pet? I know it can be wrong info if there are more than 1 deep frost mages in the party/raid, but in most cases there's only one, and it would be nice to see how much damage the elemental did. Or is it merged in with the caster's damage somehow?

    regards,
    mitch
    Posted in: General AddOns
  • 0

    posted a message on Quartz: Modular Casting Bar
    Quote from Kyahx »

    Quote from mitch0 »

    Hi,

    I can't seem to be able to set up the Global Cooldown spell. Whatever I type in just gets erased when I press the GCD button. I've tried with "Ice Lance" "Ice Lance(Rank 1)" and some other spells and combinations with rank/without rank. What am I doing wrong?

    thanks,
    mitch


    Press [Enter] when your done typing.


    Uhm, that's how I tried first. Then I tried to follow the exact instructions given when the addon is loaded (that is, click the button after entering the spellname).

    I'll double-check tonight to do an [enter] followed by [click on button]. I might have done the [enter] part with [close] after, not [click on button]...

    or I'll just edit the savedvars if all else fails...

    Posted in: General AddOns
  • 0

    posted a message on RangeCheck
    RangeCheck is a simple range display addon. It is using spell range and interact-distance based checks to determine the approximate range to your current target. If, for example, a mage's Arcane Missile spell is in range, but the character is out of follow-range (an interact distance based range), the addon will display '28 - 30'.

    See the wiki page for more details.

    I filled out the spell data for all classes now, but I could only test the Mage class extensively. Any reports from users are appreciated.

    For those with commit access: feel free to fix any bugs you find :)

    cheers,
    mitch
    Posted in: General AddOns
  • To post a comment, please or register a new account.