I've managed to find a minor bug with the Northrend Beasts encounter that is causing a boss kill to be logged when Gormok dies, not when Icehowl dies due to the fact that there are no other active living bosses known. I think i've got a solution (moving gormok + jormungars to the blacklist, leaving just icehowl in aliases) but it needs testing.
The patch is at http://paste.wowace.com/1088/ against mainline/trunk if anyone gets a chance to test it before me. An easy way to test is to switch on boss kill announces - if it announces only after Icehowl dies, its working :)
Ok, looking through the code i've worked out why sometimes loot will get assigned to Trash Mobs when its looted. Basically, when a looting message is seen like "X receives loot: Y", HeadCount attempts to work out the source of the drop by scanning every raid member's target to see if it's a boss mob, and it's dead. If a dead boss isn't targetted by anyone then it will fall through to trash mobs. So for any encounter that doesn't leave a corpse and leaves a chest instead (or just any boss that is killed but no one has the corpse targetted) won't be picked up as the default loot source and would need to be changed in the loot management popup (or manually if you don't use the popup). For bosses that do leave corpses, keeping the corpse targetted is a sure-fire way to get the loot assigned to that boss by default though.
Yeh, I often have to change trash mob to the proper boss (as the boss always gets added now, at least). There must be something that's causing the last killed boss to default to trash mobs though even when the last mob killed was a boss (which is causing the default to be wrong).
Some bosses weren't appearing in the dropdown before my wave of patches as their kills weren't recognised, but at least they are selectable now.
As i mentioned before, the HeadCount.BOSS_TARGET table isn't used at all, so adding Champion's Cache to it would be pointless at present. I'm not entirely sure why the loot is assigned to Trash Mobs when nothing else has been killed though... i'll have to investigate further.
At the moment, PT3 has sets for InstanceLoot and InstanceLootHeroic which made sense pre-3.2 as there was a clear split, but now we've got 4 raid difficulties to deal with.
I was thinking, perhaps it might be a good idea to split raid loot off from 5man instances and create sets which contains the difficulty (as determined by GetRaidDifficulty()) such as:
-- Pre-3.0
RaidLoot.Molten Core.0.Ragnaros
-- Post 3.0
RaidLoot.Naxxramas.1.Kel'Thuzad
RaidLoot.Naxxramas.2.Kel'Thuzad
Addon's could then split the set name to the general form:
RaidLoot, InstanceName, Difficulty, BossName
InstanceName and BossName as always can be looked up in Babble for localization, and Difficulty can be translated using _G["RAID_DIFFICULTY"..Difficulty], where Difficulty > 0.
I'm not sure how many others are using the InstanceLoot tables, but this is something i'm going to try and get together for ClassLoot as some private sets unless anyone has a better idea for implementation, or it gets handled by PT3 directly.
All 4 of the above events return unitID for arg1, and the UNIT_ENTER* events have further args including if the unit is using the vehicle UI and the texture to use.
Entering a vehicle fires UNIT_ENTERING_VEHICLE and UNIT_ENTERED_VEHICLE, and on leaving fires UNIT_EXITING_VEHICLE and UNIT_EXITED_VEHICLE, if that's any help :)
Just a small update to the previous patch with a couple of corrected NPC names in the Faction Champions encounter and deDE translations for most of the NPCs from yoshimo.
0
The patch is at http://paste.wowace.com/1088/ against mainline/trunk if anyone gets a chance to test it before me. An easy way to test is to switch on boss kill announces - if it announces only after Icehowl dies, its working :)
0
0
Some bosses weren't appearing in the dropdown before my wave of patches as their kills weren't recognised, but at least they are selectable now.
0
0
0
I was thinking, perhaps it might be a good idea to split raid loot off from 5man instances and create sets which contains the difficulty (as determined by GetRaidDifficulty()) such as:
-- Pre-3.0
RaidLoot.Molten Core.0.Ragnaros
-- Post 3.0
RaidLoot.Naxxramas.1.Kel'Thuzad
RaidLoot.Naxxramas.2.Kel'Thuzad
RaidLoot.Crusader's Coliseum.1.Anub'Arak
RaidLoot.Crusader's Coliseum.2.Anub'Arak
RaidLoot.Crusader's Coliseum.3.Anub'Arak
RaidLoot.Crusader's Coliseum.4.Anub'Arak
Addon's could then split the set name to the general form:
RaidLoot, InstanceName, Difficulty, BossName
InstanceName and BossName as always can be looked up in Babble for localization, and Difficulty can be translated using _G["RAID_DIFFICULTY"..Difficulty], where Difficulty > 0.
I'm not sure how many others are using the InstanceLoot tables, but this is something i'm going to try and get together for ClassLoot as some private sets unless anyone has a better idea for implementation, or it gets handled by PT3 directly.
0
<>
0
0
0
Add ruRU locale provided by StingerSoft in Ticket 104
Remove packager meta-info from SVN
0
Fixes a bug in esES locale, and a typo in one of the Twin Val'kyr's names.
0
0
Patch against mainline/trunk (r94): http://paste.wowace.com/1002/
0
0
Patch against mainline/trunk: http://paste.wowace.com/1001/