• 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from xbeeps »

    Indeed, in Triggers.lua in the function figureIconPath there's a call to BS:GetSpellIcon(), which when supplied with the "Stormstrike" string (localized or not, doesn't matter) will return the wrong icon for that ability.
    Of course i could just update LibBabble-Spell-3.0, but i'm one of those people who'd like to kill LibBabble-Spell-3.0, now that 2.4 made it redundant.

    yea, me too, that's why I already did for the CombatEvents, but I haven't found a clean way yet, to change the Triggers.lua without making the current SavedVariables/Parrot.lua invalid (yet).

    GetSpellInfo() can't get the needed Icons by spellName, but just by spellId.
    Perhaps I'll put a table in, to map old Entrys (with the name) to the correct spellId.

    edit: did it.
    If any icons on triggers stop displaying now, try setting the spellId rather than the iconname as icon.
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from xbeeps »


    The thing is that the icon for Stormstrike was changed in patch 2.4 so i'm just guessing that the icon is somehow hardcoded into Parrot via LibBabble-Spell-3.0:

    Line 2542: ["Stormstrike"] = "Spell_Holy_SealOfMight",

    This is the old icon. So instead of looking it up in babble by name, it should just be looked up with GetSpellInfo by passing the spell id from the combat log event to this function. Actually the use of LibBabble-Spell should be eliminated completely, as it is almost always possible to solve the localization problem by using GetSpellInfo.



    I already replaced all LibBabbleSpell-calls by GetSpellInfo when doing the CombatEventParsing (Code/CombatEvents.lua, Data/CombatEvents.lua).
    Only the Triggers depend on LibBabbleSpell (for now).

    Quote from falconindy »

    Mind controlling a unit results in some pretty hillarious stuff. Even after the MC wears out, Parrot continues to display inc and outgoing data for your ex-MC'd target.

    I guess blizzard combatlog passes the wrong flags here. I'll test it.
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from xbeeps »

    Should be the same

    It isn't. That's why the icon isn't retrieved correctly ;)
    Got the same on "Life Tap" which should be ID: "27222"
    but the combatlog-event passes just ID: "31818" which is just the energize-effect of "Life Tap" and has some strange Icon.
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from xbeeps »

    I think parrot still uses the old icon for stormstrike (the hammer which is also used for Hammer of Justice). It could be very nice if this was replaced with the new icon. GetSpellInfo can be used to retrieve the correct texture (spell id is 17364).

    Thanks for providing the correct spellId, but unfortunatly that doesn't help me much. I need the SpellID passed with the combatevent (most likly SPELL_DAMAGE-event). Not sure if you can provide it.

    Quote from Tatia »

    Getting allot of

    [2008/04/17 20:14:36-1005-x444]: Parrot-r70228\Code\CombatEvents.lua:1921: Bad argument #3 to `TriggerCombatEvent'. "Pet skill DoTs" is an unknown name for category "Outgoing".
    Parrot-r70228\Code\CombatEvents.lua:1392: in function `TriggerCombatEvent'
    Parrot-r70228\Code\CombatEvents.lua:1921: in function `parsefunc'
    Parrot-r70228\Code\CombatEvents.lua:2285: in function `HandleEvent'
    Parrot-r70228\Code\CombatEvents.lua:2263: in function <Interface\AddOns\Parrot\Code\CombatEvents.lua:2262>

    ---

    Tat


    should be fixed in r70248.

    Quote from Obelix »

    It appears as if Parrot is still using sharedmedia 2.0 and that those sounds that I were looking for are in 3.0... I've just changed every occurance from 2.0 to 3.0 in my local working copy. I'll leave it up to Prof_Albert to decide if he wants to change the svn copy


    also done in r70248 (why didn't I think of that?)

    Quote from Abula »

    Again not important for me, but since u asked for feedback just reporting back. Using Parrot-r70226, Bladefury icon display is still crossover with Slice n Dice.

    damn ;)
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from razoon »

    The CombatEvents.lua file is still from 3 april.
    On Files.wowace.com I see Parrot updated almost daily.
    What am I supposed to download? This seems to get messy.
    Also...who is updating Parrot: ProfAlbert or KarganMGE?? Or are they the same?

    I'm updating parrot mainly, and I put my changes in the SVN (with permission from ckk), so they are available on http://files.wowace.com. I based my version on KarganMGE's fixes.
    Other people are mostly just updating locales.
    You should download the current version from files.wowace.com

    It's often updated because there are a lot of little issues.
    The main funcionality is restored though (for 2.4-combatlog).

    btw: "Blade Flurry"-icon should work properly now (r70182). Since I don't have a rogue to test it, feedback is appreciated.
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from smurfsmurf »

    One thing that toally annoyed the crap out of me in MSBT was that the lifetap icon for incoming mana was shown as the judgement of wisdom icon, but since I updated parrot with WAU today, it's doing the same thing!

    that's an issue related to Blizzards GetSpellInfo() (introduced in 2.4).
    I replaced some localetable-lookups (libBabbleSpell) by GetSpellInfo()-calls, and i suppose Mik did that too ;)
    Quote from smurfsmurf »

    Any possible way to work around or fix this?


    there is... But is has to be done for every single spell that's broken.
    I'll start with warlock (since it is my Main)
    and perhaps replace the other calls by LibBabbleSpell-calls for the time being.

    Quote from smurfsmurf »

    And thanks alot for keeping parrot alive, much better than any of the competitors in my opinion :).


    I tried MSBT yesterday to see what I miss, but after 1 hour I couldn't stand it anymore, and continued coding on Parrot.

    edit: fixed it for "Life Tap", "Blade Flurry" coming soon
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from Refindor »

    thing is i have alot of outputs that are already in german of parrot..and the failures are just happen since the versions for 2.4

    I think the problem is the new Parrot:L-function. I'll have a look.
    maybe try http://files.wowace.com/Parrot/Parrot-r69715.zip for the time being

    The things that are german are from external Libraries (LibBabbleSpell-3.0) and blizzard's GetSpellInfo() also returns the localized string.
    Parrot itself has no deDE localeTable.

    Since I usually play on enUS locale cause I don't like the german Localisation anyways ("Jaina Prachtmeer", OMG), I don't need a german localisation.
    If you want you can add a deDE locale-table though. just look at how it's done with zhCN, koKR, etc.

    I'll look at the function again (or maybe adirelle will).
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from Anferny »

    Does that mean we can't have icons for incoming heals?

    no that means I fixed it ;) checkout the latest version it you should see the icons again.

    Quote from Anferny »

    Also for some reason I do not have pet damage scrolling (totems) anyone have ideas?

    Totems are not counted as Pets, but they must be in the combatlog somewhere I guess. I'll look for it.
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from Abula »

    Using parrot r69947, most of the bugs are fixed, for that im greatfull love this mod.

    But i dont see incoming heal icons anymore, like in the past it was

    (Holy light) 1980 <ICON>

    I setup up mine to it doesnt display text just the numbers and icon, with version 69947, i can only see text and healing amount the icons are gone (on the incoming side), but in outgoing all my melee attacks do display with the skill icon, i check both configs to see if was missing a string in the options but both are setup the same, so im not sure what cause this or how to fix it.

    Either way thx for the updates, really love parrot.


    yeah got that. it only works for selfheals, but not for heals from other sources. I'll look into it.

    edit: and fixed ;)
    GetSpellInfo(abilityName) works only when the spell is in the spellbook...
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from KarganMGE »

    but as i said in my edit. i don't think it's a good idea to show pet incomming events as player events

    That's right. That was the case with your fix in the first post (first thing that came to my eye after being absolutly amazed that Parrot worked again).
    Incoming damage on the pet, showed as incoming damage to the player. So I added new CombatEvents for incoming pet-dmg/heal etc. so it can be dealt with elsewhere.
    This "spam" can be turned off easily in the events/incoming menu now.

    (I like that spam, others don't like to see Selfheals in outgoing _and_ incoming, that's what options are for ;) )
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from KarganMGE »

    then maybe the error from adirelle might be the problem, as you are using

      L["Pet skill DoTs"]


    without registering the translation for it.

    Yep i know. that's why I removed the
    L[]
    and replaced it by a non-localised string in 68641 for now, until I figure out how to do the localisation correctly ;)
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from KarganMGE »

    the error posted by vargr is easy to find. with your last svn update you deleted the area checks to all pet events. now you are trying to handle some of the pet events as player events.

    Pet events were handled as player events before. The result is that it is displayed as player-event.
    I deleted the areachecks because I added the missing events (Incoming Pet Melee Immunes, etc)

    The events called in the posted errors are all registered in the Data/CombatEvents.lua so a possible explanation would be that they aren't registered properly. I've tried with German Client (with empty SavedVars), and the error didn't occur to me.

    Also I never touched the "Party killing blows" in Code/CombatEvents.lua:2201
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from Vargr »

    I've tested with a download of a proper version of Parrot (not with WAU) and the errors are already here :-/

    PS: Thanks to help me so much ^^

    maybe some lib in some other addon isn't initializing properly. try running Parrot without any other addons active.
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from Vargr »

    I will try this.

    EDIT: No change :-/
    Another error for the fun :

    (i've updated Parrot just before posting)

    My previous update was aproximately 3-4 days and I haven't any errors, they appears when i've update yesterday.

    hmm... it just looks like the CombatEvents aren't registered. Have you tried reinstalling yet?
    maybe check your Parrot/Data/CombatEvents.lua the events are present in the code.

    I'll try and get a french language pack, to test.
    Posted in: General AddOns
  • 0

    posted a message on Parrot 1.0 Beta for the 2.4 combat log
    Quote from Vargr »

    Some of my errors :
    I will edit my post to add the news errors
    [...]
    Very annoying, errors pops every 1-2 minutes

    have you tried deleting the savedvariables-file for parrot?
    Posted in: General AddOns
  • To post a comment, please or register a new account.