Authors CurseForge

Quote from Roxinius >>

this addon breaks the new group loot roll option was running Xloot and i was never given the window to roll on gear

 Sorry about that. Please disable Group if you attempt to use this in any non-supported version.

Quote from fantara1 >>

up

 Hey bro I voted you up too, hopefully that makes the author get it done faster

Quote from nayooz >>

Started getting a new error today.

Classic TBC 2.5.2

 

 

7x FrameXML\UIDropDownMenu.lua:72: attempt to index local 'frame' (a nil value)
[string "@FrameXML\UIDropDownMenu.lua"]:72: in function `UIDropDownMenu_Initialize'
[string "@XLoot_Master\Master-Master.lua"]:450: in main chunk

Locals:
frame = nil
initFunction = <function> defined @XLoot_Master\Master.lua:429
displayMode = "MENU"
level = nil
menuList = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'frame' (a nil value)"

 

 Disable Master.

Not sure how to fix it, don't play and don't use it. May just disable master going forward, at least on classic.

 whelp, I don't know how to mark it as 2.5.1

Edit: I've manually marked it.

Quote from Firehex1 >>

I liked this addon =) Would it be possible to updrage version for TBC classiс ? 

 Does the latest version not work for you?

What version is being suggested to you to install, and by what?

Quote from rotexor >>

Is there any way to make auto looting work with items with a comma in them?

For example "Gar'tok, Strength of the Faithful" is being read by the addon as "Gar'tok" and "Strength of the Faithful" and thus not being auto looted.

 In frame.lua: Change

for item in opt.autoloot_item_list:gmatch("%s*([^,]+)%s*") do

Figure out a character that itemlinks don't use and change , to whatever that is. Then separate with that.

Quote from madar2252 >>

Oh, cool, didn't notice the changes on the github. I like as you moved the modules under the main folder. Now an option would be useful to turn on\off the group loot or loot monitor modules - before you could just not load them at the addon selection, but now I think I cannot turn them off. Probably you can get rid of the master looter module, as they removed master loot in the previous expansion, and doesn't seem to comin back in Shadowlands either. (in classic is still goin on I believe)

 

(after a bit more testing, not sure how the loot monitor works, once it was showing what I was looting, then never again, but I didnt find any option which affect its working - I tried in solo)

 The curseforge packager pulls them out of the subfolder to allow for disable/enable, and will continue to do so in the future.

Can't really remove ML module if it's still in classic, yeah.

As far as loot monitor, I'll have to check it out when shadowlands releases. The PTR was just more than I wanted to download at once.

Glad it's helpful to you.

Quote from madar2252 >>

The PTR got the release candidate patch, so I think it's up only for one more week, if you want to log in without subscription.

The latest file on github allegedly works, I should probably try to package it.

Quote from madar2252 >>

 

 You can access the PTR now without sub. They have the Shadowlands pre-patch on it, which I guess the same environment like the beta\next expansion. I guess they will patch this up to live in a month, so probably is up there for a few weeks.

 

 

 Egh. If I get it downloaded I'll try to take a look.

It's really not sitting well with me that they chose to change things this way, it seems like most of this could happen transparently.

Quote from madar2252 >>

Unfortunately not. When I tried first, it gave lua error at start, I didn't save it, as many addons did the same, I just turned it off. Now I tried again, and at start I didn't get lua error, but when I looting something:

 

 I don't think it's going to be practical for me to fix this ahead of time, unless I can access it without a sub.

It's a simple change in concept but will potentially require a bunch of small changes that I can't remember since I really haven't touched the mod in a long time.

You might be able to get some of it working with

skins.lua:192 at the top of lib:backdrop() insert new lines:

if BackdropTemplateMixin then

  Mixin(frame, BackdropTemplateMixin)

end

Quote from madar2252 >>

Hi @xuerian, any chance for Shadowlands beta\PTR version?

Please :)

 

cheers

 Does it not work with it?

Quote from horologue >>

Those changes fixed the lua errors caused by clicking options in the config menu. As far as I can tell, the addon is now fully functional.

 

I don't know if you wish to update the formal addon on the curse page, but if you do with those two alterations, you could also mark it as working for classic.  I am going to share the fixed version with my guildmates. I will not post an updated version to the public without your permission. it's also worth noting that I know nothing about coding.

 You can share it. I was going to push an update, then I found my configuration for pushing updates is broken or out of date, and there's zero documentation for it on curseforge and I couldn't be assed.

Quote from Azona >>

This addon work mostly of time fine. only error I so far got when rolling on items comes to pass, havent copied code yet as dint went here yet to check if was even planned.

 

if I find errors and can copy whem ill post them, but wont be playing in group anymore untill later today.

Quote from horologue >>

In reply to Xuerian:

 will do. it will most likely be Tuesday as I am at PAX West for the next 4 days 

 Try this:

XLoot_Frame\Frame.lua:243

Replace

		do

 With

		if GetCurrencyInfo then

And in XLoot\helpers.lua:99

Replace

	local role = UnitGroupRolesAssigned(name)

 with

	local role = 'NONE'
	if UnitGroupRolesAssigned then
		role = UnitGroupRolesAssigned(name)
	end

Quote from Forge_User_33000768 >>

Please make a Classic version bro !!

 

Would really really appreciate it. 

 

It's the only addon missing for me now :(

 Glad to accept patches.

Quote from horologue >>

In reply to Forge_User_33000768:

 Xloot didn't work on the beta. However, I tried it again on classic yesterday, and it seems to be working fine - at least for me.

 

However, Bugsack is logging like 2 errors per second because it can't find get currency value and other things.  These bugs only start throwing when you try to configure the mod, so I've moved what I needed to and got it all set up, and then I restarted my game. so it "works" and doesn't throw errors.  It could be better though.

 If you can give me specific errors I can probably work around it, but I have no active sub and no desire to play classic either.

I can't test it due to no trial mode.

Quote from horologue >>

Is there any chance of you making a version that works for classic?

 I don't have any version planned for classic at this time.